fix: Update OpenAPIServiceConnector to new ChatMessage #8817
+264
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13162113609Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@richardpaulhudson would you please give this branch a spin in your project by directly installing it via |
vblagoje
requested review from
dfokina and
mpangrazzi
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Update
OpenAPIServiceConnectorto handle newChatMessageformatOpenAPIServiceConnectordoes not support the v2.9.xChatMessagestructure #8774What:
requestmethod in OpenAPI to handle raw responses more effectively.How can it be used:
The changes affect how
OpenAPIServiceConnectorhandles newChatMessageformat involving build intool_callsproperty.Example usage:
Where
messageshould now containtool_callsproperty.How did you test it:
Tests verify new behavior of message processing with checks for valid tool calls. Patched OpenAPI methods are mocked to assess correct invocation and response handling. Integration tests are skipped unless specific API keys are set.
Notes for the reviewer:
Pay special attention to the new patch applied to the
requestmethod of OpenAPI, specifically concerning raw response handling. Ensure the test coverage is sufficient for edge cases in tool call processing and response verification.