You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The internal parameters of the new ChatMessage class (e.g. _content) can be left unchanged.
Describe alternatives you've considered
Leave as it is: I am very unhappy about adding these extra underscores as a part of the request to my currently deployed pipelines. No matter the parameters are internal or not, the changes should not extend to its serialized form.
Additional context
I put a comment in the PR (#8640) before it was merged but it still slipped through despite multiple pings. I am a little disappointed to be very honest and I hope the communication could have been a little clearer.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Following the leftover comment from #8640 (comment)
Describe the solution you'd like
ChatMessage serialization/deserialization should not use underscores in its json format.
It makes much more sense to write
rather than
as the serialized input of a pipeline.
The internal parameters of the new ChatMessage class (e.g.
_content
) can be left unchanged.Describe alternatives you've considered
Leave as it is: I am very unhappy about adding these extra underscores as a part of the request to my currently deployed pipelines. No matter the parameters are internal or not, the changes should not extend to its serialized form.
Additional context
I put a comment in the PR (#8640) before it was merged but it still slipped through despite multiple pings. I am a little disappointed to be very honest and I hope the communication could have been a little clearer.
The text was updated successfully, but these errors were encountered: