From ea14a19b627a35333a77ce356deb99d34aa6a2ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Orosz?= Date: Wed, 5 Feb 2025 16:53:29 +0100 Subject: [PATCH] refactor: encode_kwargs parameter of SentenceTransformersDocumentEmbedder and SentenceTransformersTextEmbedder mae to be the last positional parameter for backward compatibility (part II.) --- .../embedders/sentence_transformers_document_embedder.py | 2 +- .../components/embedders/sentence_transformers_text_embedder.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/haystack/components/embedders/sentence_transformers_document_embedder.py b/haystack/components/embedders/sentence_transformers_document_embedder.py index da804edde0..0125be3f5c 100644 --- a/haystack/components/embedders/sentence_transformers_document_embedder.py +++ b/haystack/components/embedders/sentence_transformers_document_embedder.py @@ -160,8 +160,8 @@ def to_dict(self) -> Dict[str, Any]: model_kwargs=self.model_kwargs, tokenizer_kwargs=self.tokenizer_kwargs, config_kwargs=self.config_kwargs, - encode_kwargs=self.encode_kwargs, precision=self.precision, + encode_kwargs=self.encode_kwargs, ) if serialization_dict["init_parameters"].get("model_kwargs") is not None: serialize_hf_model_kwargs(serialization_dict["init_parameters"]["model_kwargs"]) diff --git a/haystack/components/embedders/sentence_transformers_text_embedder.py b/haystack/components/embedders/sentence_transformers_text_embedder.py index cf01495668..2cb1622e97 100644 --- a/haystack/components/embedders/sentence_transformers_text_embedder.py +++ b/haystack/components/embedders/sentence_transformers_text_embedder.py @@ -49,8 +49,8 @@ def __init__( # noqa: PLR0913 # pylint: disable=too-many-positional-arguments model_kwargs: Optional[Dict[str, Any]] = None, tokenizer_kwargs: Optional[Dict[str, Any]] = None, config_kwargs: Optional[Dict[str, Any]] = None, - encode_kwargs: Optional[Dict[str, Any]] = None, precision: Literal["float32", "int8", "uint8", "binary", "ubinary"] = "float32", + encode_kwargs: Optional[Dict[str, Any]] = None, ): """ Create a SentenceTransformersTextEmbedder component.