Skip to content

Commit

Permalink
feat: Split linting preview into a separate file (#6017)
Browse files Browse the repository at this point in the history
* Split linting preview into seperate file

* Add not trigger paths in old workflow
  • Loading branch information
vblagoje authored Oct 10, 2023
1 parent 98215ae commit c05f564
Show file tree
Hide file tree
Showing 2 changed files with 82 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
paths:
- "**.py"
- "**/pyproject.toml"
- "!haystack/preview/**/*.py"
- "!test/preview/**/*.py"

env:
PYTHON_VERSION: "3.8"
Expand Down
80 changes: 80 additions & 0 deletions .github/workflows/linting_preview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
# If you change this name also do it in linting-skipper.yml and ci_metrics.yml
name: Linting (Preview)

on:
pull_request:
paths:
- "haystack/preview/**/*.py"
- "test/preview/**/*.py"
- "**/pyproject.toml"

env:
PYTHON_VERSION: "3.8"

jobs:
mypy:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
# With the default value of 1, there are corner cases where tj-actions/changed-files
# fails with a `no merge base` error
fetch-depth: 0

- name: Get changed files
id: files
uses: tj-actions/changed-files@v39
with:
files: |
**/*.py
files_ignore: |
test/**
rest_api/test/**
- uses: actions/setup-python@v4
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Haystack
run: pip install .[dev,preview] langdetect transformers[torch,sentencepiece]==4.32.1 'sentence-transformers>=2.2.0' pypdf openai-whisper tika 'azure-ai-formrecognizer>=3.2.0b2'

- name: Mypy
if: steps.files.outputs.any_changed == 'true'
run: |
mkdir .mypy_cache/
mypy --install-types --non-interactive ${{ steps.files.outputs.all_changed_files }} --exclude=rest_api/build/ --exclude=rest_api/test/
pylint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
# With the default value of 1, there are corner cases where tj-actions/changed-files
# fails with a `no merge base` error
fetch-depth: 0

- name: Get changed files
id: files
uses: tj-actions/changed-files@v39
with:
files: |
**/*.py
files_ignore: |
test/**
rest_api/test/**
- uses: actions/setup-python@v4
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Haystack
run: |
pip install .[dev,preview] langdetect transformers[torch,sentencepiece]==4.32.1 'sentence-transformers>=2.2.0' pypdf openai-whisper tika 'azure-ai-formrecognizer>=3.2.0b2'
pip install ./haystack-linter
- name: Pylint
if: steps.files.outputs.any_changed == 'true'
run: |
pylint -ry -j 0 ${{ steps.files.outputs.all_changed_files }}

0 comments on commit c05f564

Please sign in to comment.