Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit from FilterDocumentsTestWithDataframe in Document Stores tests after Haystack 2.9.0 release #1280

Closed
anakin87 opened this issue Jan 8, 2025 · 0 comments · Fixed by #1290
Assignees
Labels

Comments

@anakin87
Copy link
Member

anakin87 commented Jan 8, 2025

In deepset-ai/haystack#8684, we isolated the dataframe tests in the Haystack docstore test suite.
This was done in preparation for the eventual deprecation and removal of dataframe field from Haystack Document - see deepset-ai/haystack#8627.

Until a decision is made to proceed with the deprecation process,
after the 2.9.0 release, we should make the Document Stores test suites inherit from FilterDocumentsTestWithDataframe, so that tests on dataframes will keep running.

This can potentially be done in a single PRs since adapting tests does not require new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants