-
Notifications
You must be signed in to change notification settings - Fork 33
Closed
Labels
Description
We are using f-strings in almost all log calls.
On codebase, there are log.trace or log.debug calls which are not evaluated due to log level, but f-string are eagerly evaluated so this means a small performance drop. Even in most of the cases this is negligible, it's would be good to fix it.
Example:
# Using f-strings
log.success(f"YAML pipeline '{pipeline_name}' successfully added to registry")
# Using braces format (better)
log.success("YAML pipeline '{}' successfully added to registry", pipeline_name)
References:
- Loguru braces style docs: https://github.com/Delgan/loguru?tab=readme-ov-file#modern-string-formatting-using-braces-style