Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript support for tab #12

Open
BekahHW opened this issue Oct 12, 2022 · 5 comments
Open

Add TypeScript support for tab #12

BekahHW opened this issue Oct 12, 2022 · 5 comments
Assignees
@AlexVCS

Comments

@BekahHW
Copy link
Contributor

BekahHW commented Oct 12, 2022

Proposed changes

In popup.ts we're getting some warnings for tabId and tab.id. Update to use types and eliminate the warnings.
@JesseRWeigel
Copy link

Can I take this one?

@BekahHW
Copy link
Contributor Author

BekahHW commented Oct 17, 2022

@JesseRWeigel all you!

@BekahHW BekahHW assigned BekahHW and JesseRWeigel and unassigned BekahHW Oct 17, 2022
@AlexVCS
Copy link

AlexVCS commented Oct 28, 2022

Hey there, I'd like to work on this issue!

@BekahHW BekahHW assigned AlexVCS and unassigned JesseRWeigel Oct 28, 2022
@AlexVCS
Copy link

AlexVCS commented Oct 28, 2022

I haven't done TS much, but I see tabId and tab.id are initially mentioned on line 16. Am I going to be doing something similar to what you've got on line 60, APIKey?.setAttribute('type', type)? Thanks

@BekahHW
Copy link
Contributor Author

BekahHW commented Oct 29, 2022

Hey @AlexVCS when you hover over tab.id, what information are you seeing about why TS isn't ok with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVCS AlexVCS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JesseRWeigel @BekahHW @AlexVCS