Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vsp library public #2033

Open
oshorefueled opened this issue Apr 26, 2021 · 3 comments
Open

make vsp library public #2033

oshorefueled opened this issue Apr 26, 2021 · 3 comments

Comments

@oshorefueled
Copy link

Currently the vsp library is in the internal directory making it impossible to use the code outside dcrwallet. Making it public would eliminate the need to replicate it in dclibwallet used by dcrandroid, dcrios and godcr.

@xaur
Copy link

xaur commented Jul 16, 2023

I guess this will be addressed by #2237

@xaur
Copy link

xaur commented Sep 21, 2023

I believe the plan has changed. decred/vspd#382 introduced a circular dependency that was problematic. As a result decred/vspd#395 and #2237 got canceled, and VSP code that made it into the vspd reporisoty was removed in decred/vspd#403 . I think the new plan is to keep the VSP client in dcrwallet repo and make it an exported/reusable package.

@JoeGruffins
Copy link
Member

closed by #2359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants