Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcrdata/exchanges: connect to signalR websocket without signalR client #1945

Closed
wants to merge 2 commits into from
Closed

dcrdata/exchanges: connect to signalR websocket without signalR client #1945

wants to merge 2 commits into from

Conversation

ukane-philemon
Copy link
Contributor

@ukane-philemon ukane-philemon commented Dec 8, 2022 •
edited
Loading

This implements a connectSignalRWebsocket function which is used to connect to a signalR websocket without a signalR client. The connection is done in three steps (negotiate, connect, start) and this makes it easy to connect to a signalR websocket without having to manage the signalR websocket connection separately from the regular websocket connection used by other exchanges. Closes #1818

  • Remove external dependency used to connect to a signalR websocket
  • Fix an error in the exchanges live test.
  • Update bittrex signalR websocket version.

For a quick test:

$ go test --tags livexc -run TestBittrexLiveWebsocket                 
2022-12-08 14:03:50.987 [TRC] EXE: Initializing websocket connection for bittrex
2022-12-08 14:03:52.843 [TRC] EXE: Signalling candlestick update for bittrex, bin size 1d
2022-12-08 14:03:53.235 [TRC] EXE: Signalling candlestick update for bittrex, bin size 1h
Bittrex emitted an exchange update: 115 bids, 500 asks, 0 candlestick sets 
2022-12-08 14:03:59.164 [TRC] EXE: last bittrex websocket update 0.000 seconds ago
Bittrex emitted an exchange update: 115 bids, 500 asks, 2 candlestick sets

@ukane-philemon
connect to signalR websocket without signalR client
41530d3 
- Remove external dependency used to connect to a signalR websocket.
- Fix an error in the exchanges live test.
- Update bittrex signalR websocket version.
@chappjc
Copy link
Member

chappjc commented Dec 8, 2022

Excellent work with this. Really simplifies things as a bonus on top of eliminating the dependency.

@chappjc
Copy link
Member

chappjc commented Jan 24, 2024

Good work, but looks like trex was the only consumer of microsoft nonsense, so we'll close this this update. I really do appreciate it though.

@chappjc chappjc closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exchanges: need new signalr client
2 participants
@ukane-philemon @chappjc