Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove public facing lane index references #212

Open
jkeon opened this issue Apr 14, 2023 · 0 comments
Open

Remove public facing lane index references #212

jkeon opened this issue Apr 14, 2023 · 0 comments

Comments

@jkeon
Copy link
Member

jkeon commented Apr 14, 2023

In DataStreamPendingWriter (and others) there is an API to allow you to Add and pass in the lane index.

The lane index is NOT the NativeThreadIndex and this could be confusing to developers when they are running jobs that aren't in a TaskDriver job. Ex. Entities.ForEach.

We can probably remove any public facing mention of a lane index and instead have the [NativeSetThreadIndex] attribute on the writer itself. This would eliminate the need for the InitOnThread method on the writer and would ensure that regardless of the job type you are using, the instance has the correct LaneWriter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant