Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RectUtil.CreateBoundingRect - Explore Optimizations #99

Open
mbaker3 opened this issue Dec 7, 2022 · 0 comments
Open

RectUtil.CreateBoundingRect - Explore Optimizations #99

mbaker3 opened this issue Dec 7, 2022 · 0 comments
Labels
effort-medium Standard - 2 to 4 hours priority-low Get to it when you get to it. No rush. type-chore Clean-up and optimization

Comments

@mbaker3
Copy link
Member

mbaker3 commented Dec 7, 2022

Current implementation is "gut feel" most efficient but different approaches should be profiled.

Ideas:

  • Do math.min(i + 2, points.Length) instead of (i + 1) % points.Length to avoid potential cache invalidation on super long collections
  • Strides of 4 but do a separate math.min(batchMinX, minX) call
  • Is it even worth batching?
@mbaker3 mbaker3 added effort-medium Standard - 2 to 4 hours priority-low Get to it when you get to it. No rush. type-chore Clean-up and optimization labels Dec 7, 2022
@mbaker3 mbaker3 mentioned this issue Dec 7, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-medium Standard - 2 to 4 hours priority-low Get to it when you get to it. No rush. type-chore Clean-up and optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbaker3