Skip to content

Commit bb6c2c3

Browse files
committed
revert to Skia rendering engine
1 parent cbaaf2f commit bb6c2c3

File tree

5 files changed

+16
-3
lines changed

5 files changed

+16
-3
lines changed

.github/workflows/release.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,20 @@ jobs:
4343
# `KEY_JKS` should contain the result of:
4444
# gpg -c --armor keystore.jks
4545
# `KEY_JKS_PASSPHRASE` should contain the passphrase used for the command above
46+
# The SkSL bundle must be produced with the same Flutter engine as the one used to build the artifact
47+
# flutter build <subcommand> --bundle-sksl-path shaders.sksl.json
48+
# do not bundle shaders for izzy/libre flavours, to avoid crashes in some environments:
49+
# cf https://github.com/deckerst/aves/issues/388
50+
# cf https://github.com/deckerst/aves/issues/398
4651
run: |
4752
echo "${{ secrets.KEY_JKS }}" > release.keystore.asc
4853
gpg -d --passphrase "${{ secrets.KEY_JKS_PASSPHRASE }}" --batch release.keystore.asc > $AVES_STORE_FILE
4954
rm release.keystore.asc
5055
mkdir outputs
5156
scripts/apply_flavor_play.sh
52-
./flutterw build appbundle -t lib/main_play.dart --flavor play
57+
./flutterw build appbundle -t lib/main_play.dart --flavor play --bundle-sksl-path shaders.sksl.json
5358
cp build/app/outputs/bundle/playRelease/*.aab outputs
54-
./flutterw build apk -t lib/main_play.dart --flavor play
59+
./flutterw build apk -t lib/main_play.dart --flavor play --bundle-sksl-path shaders.sksl.json
5560
cp build/app/outputs/apk/play/release/*.apk outputs
5661
scripts/apply_flavor_izzy.sh
5762
./flutterw build apk -t lib/main_izzy.dart --flavor izzy --split-per-abi

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
## <a id="unreleased"></a>[Unreleased]
66

7+
### Changed
8+
9+
- revert to Skia rendering engine
10+
711
## <a id="v1.12.10"></a>[v1.12.10] - 2025-04-16
812

913
### Added

android/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,6 @@
331331
android:value="2" />
332332
<meta-data
333333
android:name="io.flutter.embedding.android.EnableImpeller"
334-
android:value="true" />
334+
android:value="false" />
335335
</application>
336336
</manifest>

pubspec.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ flutter:
160160
################################################################################
161161
# Test driver
162162

163+
# capture shaders (profile mode, real device only):
164+
# % ./flutterw drive --flavor play -t test_driver/driver_shaders.dart --profile --cache-sksl --write-sksl-on-exit shaders.sksl.json
165+
163166
# generate screenshots (profile mode, specific collection):
164167
# % ./flutterw drive --flavor play -t test_driver/driver_screenshots.dart --profile
165168

shaders.sksl.json

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)