Fix image upload and resolver and use CommonMark #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akhu
reviewed
Jul 22, 2020
| $pureTitle = strip_tags($render); | ||
|
|
||
| if ($block instanceof Heading) { | ||
| $this->headers[] = ["text" => $pureTitle, "level" => $level = $block->getLevel(), "id" => $id = "h$level-" . $this->slugify($pureTitle) . "-" . substr(md5($render), 0, 10)]; |
There was a problem hiding this comment.
If possible, indenting theses long multi parameters string in vertical to be more readable.
["text" => $pureTitle,
"level" => $level = $block->getLevel(),
...,
]
Akhu
reviewed
Jul 22, 2020
|
|
||
|
|
||
|
|
||
| public function extractTOC() |
There was a problem hiding this comment.
Breaking this function into multiple chunks will help maintaining and understanding the code later
Akhu
reviewed
Jul 22, 2020
| if (count($lastOfLevel) < 1) { | ||
| $tree[] = &$c; | ||
| } | ||
| $lastOfLevel[$c["level"]] = &$c; |
There was a problem hiding this comment.
Avoid abbreviating variable please :/
Akhu
reviewed
Jul 22, 2020
|
|
||
| } | ||
|
|
||
| private function slugify($string, $delimiter = '-') |
There was a problem hiding this comment.
Quick comment to summarize what will be cleaned after this function. Or a link to a standard "slugify" process explanation
Akhu
reviewed
Jul 22, 2020
| return ["!"]; | ||
| } | ||
|
|
||
| public function parse(InlineParserContext $inlineContext): bool |
There was a problem hiding this comment.
Break this function into small reusable chunks will help maintaining the code.
Also a quick comment to explain whats happening here
Akhu
reviewed
Jul 22, 2020
| throw new \InvalidArgumentException('Incompatible inline type: ' . get_class($inline)); | ||
| } | ||
| dump($inline); | ||
| $style = implode("", array_map(fn($k, $v) => "$k: {$v}px;", array_keys($inline->getData("size", [])), array_values($inline->getData("size", [])))); |
There was a problem hiding this comment.
Multiline syntax for parameters help readability here.
Akhu
reviewed
Jul 22, 2020
|
|
||
| use Symfony\Component\Finder\SplFileInfo; | ||
|
|
||
| class File |
There was a problem hiding this comment.
Purpose of this POPO as comment can help
Akhu
reviewed
Jul 22, 2020
| public SerializerInterface $serializer; | ||
|
|
||
|
|
||
| public function parse(MarkdownFile &$file) |
There was a problem hiding this comment.
Why parsing Markdown is done with PHP and not by the front-end ?
…by default" This reverts commit 48776e9.
* adding trusted_proxies for dev and public opened to everyone by default * Revert "adding trusted_proxies for dev and public opened to everyone by default" This reverts commit 48776e9. * adding permission + fix upload/edit file * adding readonly info * update for passing through twig constants * fix: move settings to plugins * quick fix typo in delete * fix: removing route for settings
* adding trusted_proxies for dev and public opened to everyone by default * Revert "adding trusted_proxies for dev and public opened to everyone by default" This reverts commit 48776e9. * fix: setting default to fileName * fix: quick fix for a not existing file
* adding trusted_proxies for dev and public opened to everyone by default * Revert "adding trusted_proxies for dev and public opened to everyone by default" This reverts commit 48776e9. * adding meta title to page - needs more styling I think * fix: style test * move article title and make it optionnal * removing computed for current metadata * fix: removing extra useless component
* Revert "adding trusted_proxies for dev and public opened to everyone by default" This reverts commit 48776e9. * adding meta title to page - needs more styling I think * fix: style test * move article title and make it optionnal * removing computed for current metadata * fix: removing extra useless component * adding custom header metadata handler * rebasing * removing unwanted changes * fix: removing useless changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65