remove out of attempts (#94)

Author: NickKhalow

core/Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "dcl-launcher-core"
-version = "1.3.0"
+version = "1.3.1"
 edition = "2024"
 
 [lib]

core/Cargo.toml

@@ -8,14 +8,12 @@ use super::types::Status;
 
 pub struct FlowError {
     pub user_message: String,
-    pub can_retry: bool,
 }
 
 impl From<&FlowError> for Status {
     fn from(err: &FlowError) -> Self {
         Status::Error {
             message: err.user_message.to_owned(),
-            can_retry: err.can_retry,
         }
     }
 }

core/src/attempts.rs

@@ -1,9 +1,8 @@
 use crate::channel::EventChannel;
 use crate::{
     analytics::{Analytics, event::Event},
-    attempts::Attempts,
     environment::AppEnvironment,
-    errors::{FlowError, StepError, StepResult},
+    errors::{FlowError, StepResult},
     installs::{self, InstallsHub},
     s3::{self, ReleaseResponse},
     types::{BuildType, Status, Step},
@@ -50,8 +49,7 @@ trait LaunchStep {
 #[derive(Default)]
 pub struct LaunchFlowState {
     latest_release: Option<ReleaseResponse>,
-    recent_download: Option<RecentDownload>,
-    attempts: Attempts,
+    recent_download: Option<RecentDownload>
 }
 
 #[derive(Clone)]
@@ -90,10 +88,8 @@ impl LaunchFlow {
         if let Err(e) = result {
             log::error!("Error during the flow {} {:#?}", e, e);
             sentry::capture_error(&e);
-            let can_retry = Self::can_retry(state).await;
             let error = FlowError {
-                user_message: e.user_message().to_owned(),
-                can_retry,
+                user_message: e.user_message().to_owned()
             };
             return std::result::Result::Err(error);
         }
@@ -106,7 +102,6 @@ impl LaunchFlow {
         channel: &T,
         state: Arc<Mutex<LaunchFlowState>>,
     ) -> StepResult {
-        Self::validate_attempt_and_increase(state.clone()).await?;
         self.fetch_step
             .execute_if_needed(channel, state.clone(), "fetch")
             .await?;
@@ -121,27 +116,6 @@ impl LaunchFlow {
             .await?;
         StepResult::Ok(())
     }
-
-    async fn validate_attempt_and_increase(state: Arc<Mutex<LaunchFlowState>>) -> StepResult {
-        let mut guard = state.lock().await;
-
-        if guard.attempts.try_consume_attempt() {
-            return StepResult::Ok(());
-        }
-
-        let message = "Out of attempts";
-        let inner_error = anyhow!(message);
-        let error = StepError::E0000_GENERIC_ERROR {
-            error: inner_error,
-            user_message: Some(message.to_owned()),
-        };
-        StepResult::Err(error)
-    }
-
-    async fn can_retry(state: Arc<Mutex<LaunchFlowState>>) -> bool {
-        let guard = state.lock().await;
-        guard.attempts.can_retry()
-    }
 }
 
 struct FetchStep {}

core/src/errors.rs

@@ -1,6 +1,5 @@
 pub mod analytics;
 pub mod app;
-mod attempts;
 pub mod channel;
 mod config;
 pub mod environment;

core/src/flow.rs

@@ -6,7 +6,7 @@ pub enum Status {
     #[serde(rename_all = "camelCase")]
     State { step: Step },
     #[serde(rename_all = "camelCase")]
-    Error { message: String, can_retry: bool },
+    Error { message: String },
 }
 
 #[derive(Clone, Serialize)]

core/src/lib.rs

@@ -1,7 +1,7 @@
 {
   "name": "Decentraland",
   "private": true,
-  "version": "1.3.0",
+  "version": "1.3.1",
   "type": "module",
   "scripts": {
     "dev": "vite",