Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportError due to importing tests that depend on pandas #4

Open
johnyf opened this issue Jun 4, 2017 · 1 comment · May be fixed by #6
Open

ImportError due to importing tests that depend on pandas #4

johnyf opened this issue Jun 4, 2017 · 1 comment · May be fixed by #6

Comments

@johnyf
Copy link

johnyf commented Jun 4, 2017

The module ballpark.__init__ imports ballpark.tests (no need to import tests at runtime), and the module ballpark.tests imports pandas, which is absent from install_requires. As a result, after installing with pip:

In [3]: import ballpark
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-3-21d6fb214fd5> in <module>()
----> 1 import ballpark

/.../site-packages/ballpark/__init__.py in <module>()
----> 1 from . import notation, shortcuts, statistics, tests
      2 from .notation import order, extent
      3 from .notation import scientific, engineering, business
      4 from .utils import quantize, floor, ceil, round
      5 

/.../site-packages/ballpark/tests.py in <module>()
      4 import unittest
      5 
----> 6 import pandas
      7 
      8 from . import notation

ImportError: No module named 'pandas'

Not importing any tests at runtime, and adding tests_require=['pandas'] in the setup.py should address this issue. Relevant to #3.
@facastagnini
Copy link

I second this petition, it is very expensive to install pandas on a raspberry pi :(

@facastagnini facastagnini linked a pull request Dec 31, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving test out of __init__ facastagnini/python-ballpark
2 participants
@facastagnini @johnyf