Update plex_update.ps1 #45
Conversation
Fixed partial scan on changes
Watermelon AI SummaryAI Summary deactivated by fatbob01 GitHub PRs
zurg-testing is an open repo and Watermelon will serve it for free. |
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files selected for processing (1)
- plex_update.ps1 (1 hunks)
Additional comments: 1
plex_update.ps1 (1)
- 1-1: Adding the
System.Webassembly is necessary for theHttpUtility::UrlEncodemethod to be available.
| $plex_url = "http://yourplexip:32400" | ||
| $token = "YourPlexTokenHere" | ||
| $zurg_mount = "YourZurgMountLetterHere:" |
There was a problem hiding this comment.
Ensure that the $plex_url and $token variables are assigned from a secure source or environment variables to prevent hardcoding sensitive information.
| # sudo apt install python3 | ||
| $plex_url = "http://yourplexip:32400" | ||
| $token = "YourPlexTokenHere" | ||
| $zurg_mount = "YourZurgMountLetterHere:" |
There was a problem hiding this comment.
Consider validating the $section_ids to ensure that the script received a valid response from the Plex server before proceeding.
| Write-Host "Detected update on: $arg" | ||
| Write-Host "Absolute path: $modified_arg" | ||
|
|
||
| # URL Encode the path | ||
| $encoded_arg = [System.Web.HttpUtility]::UrlEncode($modified_arg) | ||
|
|
||
| if ([string]::IsNullOrEmpty($encoded_arg)) { | ||
| Write-Host "Error: Encoded argument is empty. Check the input or encoding process." | ||
| continue | ||
| } | ||
|
|
||
| # Additional escaping logic here if necessary | ||
| # For instance, if certain characters are not being correctly escaped by UrlEncode, | ||
| # you can add custom replace commands here. | ||
|
|
||
| foreach ($section_id in $section_ids) { | ||
| $final_url = "${plex_url}/library/sections/${section_id}/refresh?path=${encoded_arg}&X-Plex-Token=${token}" |
There was a problem hiding this comment.
The construction of $final_url directly interpolates the encoded argument and token into the URL. Ensure that the token is securely handled and that the URL construction does not introduce any vulnerabilities, such as URL injection.
| # Additional escaping logic here if necessary | ||
| # For instance, if certain characters are not being correctly escaped by UrlEncode, | ||
| # you can add custom replace commands here. | ||
|
|
||
| foreach ($section_id in $section_ids) { | ||
| $final_url = "${plex_url}/library/sections/${section_id}/refresh?path=${encoded_arg}&X-Plex-Token=${token}" |
There was a problem hiding this comment.
The final message indicates completion. Consider adding error handling to provide feedback if any web requests fail.
Fixed partial scan on changes
Summary by CodeRabbit