Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: don't return unpublished albums and images from unpublished albums #59

Open
deanmoses opened this issue Dec 23, 2023 · 0 comments

Comments

@deanmoses
Copy link
Owner

deanmoses commented Dec 23, 2023

Search currently returns unpublished albums and images in those albums. That's a bug; those results will be unclickable by non-admins.

Implementation Notes

To not return images from unpublished albums, the lambda that receives the Redis search results would have to bulk retrieve all the albums for the images in order to check their publish status.

I rejected an alternative implementation, which was to not index images from unpublished albums. But when the album IS published, DynamoDB won't re-stream those images because they aren't changed, which means they'll never get indexed. Since we do all edits BEFORE publishing the album, no image would ever get indexed.

I'm okay leaving this bug for now, given that search is unlikely to return a result in the latest album, and the consequence of doing so is just an unclickable search result.

@deanmoses deanmoses added this to the AWS v1 milestone Dec 23, 2023
@deanmoses deanmoses changed the title Search doesn't return unpublished albums and images from unpublished albums Search shouldn't return unpublished albums and images from unpublished albums Dec 23, 2023
@deanmoses deanmoses removed this from the AWS v1 milestone Dec 30, 2023
@deanmoses deanmoses changed the title Search shouldn't return unpublished albums and images from unpublished albums Search: don't return unpublished albums and images from unpublished albums Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant