From 52fe216487b5da0f52d0a4464e72f036ec76a896 Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Fri, 30 Nov 2018 12:47:08 -0500 Subject: [PATCH 1/2] Remove sentry dsn check from pre-release script we dont actually use this and its blocking release now. Releases just happened to work in the past because node 4 would do the deploy which doesnt run the prerelease script --- scripts/pre-release.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/pre-release.js b/scripts/pre-release.js index b8afb24ce32..bddc8ecc76f 100644 --- a/scripts/pre-release.js +++ b/scripts/pre-release.js @@ -7,9 +7,11 @@ const path = require('path'); const trackingConfigFilePath = path.join(process.cwd(), getTrackingConfigFileName()); // don't release without Sentry key! +/* if (!process.env.SENTRY_DSN) { throw new Error('SENTRY_DSN env var not set'); } +*/ const trackingConfig = { sentryDSN: process.env.SENTRY_DSN, From 3f9fbd111a55d6515216d165b65cceb0e8d14ead Mon Sep 17 00:00:00 2001 From: Daniel Schep Date: Fri, 30 Nov 2018 13:11:24 -0500 Subject: [PATCH 2/2] switch to disabling prepuplish only script --- package.json | 3 +-- scripts/pre-release.js | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index 64269b8b196..d3aae4fdb66 100644 --- a/package.json +++ b/package.json @@ -58,8 +58,7 @@ "integration-test-cleanup": "node scripts/integration-test-cleanup.js", "simple-integration-test": "jest --maxWorkers=5 simple-suite", "complex-integration-test": "jest --maxWorkers=5 integration", - "postinstall": "node ./scripts/postinstall.js", - "prepublishOnly": "./scripts/shrinkwrap && node ./scripts/pre-release.js" + "postinstall": "node ./scripts/postinstall.js" }, "jest": { "testRegex": "(\\.|/)(tests)\\.js$", diff --git a/scripts/pre-release.js b/scripts/pre-release.js index bddc8ecc76f..b8afb24ce32 100644 --- a/scripts/pre-release.js +++ b/scripts/pre-release.js @@ -7,11 +7,9 @@ const path = require('path'); const trackingConfigFilePath = path.join(process.cwd(), getTrackingConfigFileName()); // don't release without Sentry key! -/* if (!process.env.SENTRY_DSN) { throw new Error('SENTRY_DSN env var not set'); } -*/ const trackingConfig = { sentryDSN: process.env.SENTRY_DSN,