Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microbatch] Update tests to use microbatch behavior flag #537

Closed
QMalcolm opened this issue Oct 1, 2024 · 2 comments
Closed

[Microbatch] Update tests to use microbatch behavior flag #537

QMalcolm opened this issue Oct 1, 2024 · 2 comments
Labels
feature:microbatch Issues related to the microbatch incremental strategy pkg:dbt-bigquery Issue affects dbt-bigquery type:task Eng-driven work

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Oct 1, 2024

In dbt-labs/dbt-bigquery#1334 we implemented the microbatch strategy. As part of that we setup the related tests to an enviornment variable for access the microbatch strategy, as that is what core had implemented. However, dbt-core is moving to using a project flag / behavior flag for this functionality instead of an environment variable (dbt-labs/dbt-core#10799). We need to update our tests to reflect this. The behavior flag is being added via dbt-adapters (#323).

@amychen1776
Copy link
Contributor

amychen1776 commented Jan 6, 2025

@QMalcolm will you be updating these tests?

@mikealfare mikealfare added type:task Eng-driven work feature:microbatch Issues related to the microbatch incremental strategy pkg:dbt-bigquery Issue affects dbt-bigquery labels Jan 14, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-bigquery Jan 14, 2025
@QMalcolm
Copy link
Contributor Author

This testing ended up not being necessary as the logically important changes gated by the behavior flag are dealt with in dbt-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:microbatch Issues related to the microbatch incremental strategy pkg:dbt-bigquery Issue affects dbt-bigquery type:task Eng-driven work
Projects
None yet
3 participants