Improve trigger 'scope' attribute support (RT#119997)

- JSON, YAML and XML producers
- XML and SQLite parsers

TODO: Unify with the DB2 parser/producer's 'granularity' extra attribute

Author: ilmari

Changes

@@ -8,6 +8,8 @@ Changes for SQL::Translator
  * Add support for USING and WHERE on indexes in PostgreSQL producer
    and parser (RT#63814, GH#52)
  * Improve add_trigger consistency between producers (GH#48)
+ * Add trigger 'scope' attribute support to JSON, YAML and XML producers,
+   and XML and SQLite parsers (RT#119997)
  * Declare dependencies in deterministic order (RT#102859)
  * Multiple speedups of naive internal debugging mechanism (GH#54)
  * Remove dependency on List::MoreUtils ( http://is.gd/lmu_cac_debacle )

lib/SQL/Translator/Parser/SQLite.pm

@@ -730,6 +730,7 @@ sub parse {
             database_events     => $def->{'db_events'},
             action              => $def->{'action'},
             on_table            => $def->{'on_table'},
+            scope               => 'row', # SQLite only supports row triggers
         );
     }
 

lib/SQL/Translator/Parser/XML/SQLFairy.pm

@@ -216,7 +216,7 @@ sub parse {
     foreach (@nodes) {
         my %data = get_tagfields($xp, $_, "sqlf:", qw/
             name perform_action_when database_event database_events fields
-            on_table action order extra
+            on_table action order extra scope
         /);
 
         # back compat

lib/SQL/Translator/Producer/JSON.pm

@@ -149,6 +149,7 @@ sub view_trigger {
         'fields'              => scalar $trigger->fields,
         'on_table'            => scalar $trigger->on_table,
         'action'              => scalar $trigger->action,
+        'scope'               => scalar $trigger->scope,
         keys %{$trigger->extra} ? ('extra' => { $trigger->extra } ) : (),
     };
 }

lib/SQL/Translator/Producer/XML/SQLFairy.pm

@@ -271,7 +271,7 @@ sub produce {
     xml_obj_children( $xml, $schema,
         tag    => 'trigger',
         methods => [qw/name database_events action on_table perform_action_when
-            fields order extra/],
+            fields order extra scope/],
     );
 
     #

lib/SQL/Translator/Producer/YAML.pm

@@ -148,6 +148,7 @@ sub view_trigger {
         'fields'              => scalar $trigger->fields,
         'on_table'            => scalar $trigger->on_table,
         'action'              => scalar $trigger->action,
+        'scope'               => scalar $trigger->scope,
         keys %{$trigger->extra} ? ('extra' => { $trigger->extra } ) : (),
     };
 }

lib/Test/SQL/Translator.pm

@@ -284,6 +284,9 @@ sub trigger_ok {
     is( $obj->on_table, $test->{on_table},
         "$t_name    on_table is '$test->{on_table}'" );
 
+    is( $obj->scope, $test->{scope}, "$t_name    scope is '$test->{scope}'" )
+        if exists $test->{scope};
+
     is( $obj->action, $test->{action}, "$t_name    action is '$test->{action}'" );
 
     is_deeply( { $obj->extra }, $test->{extra}, "$t_name    extra" );

t/16xml-parser.t

@@ -27,7 +27,7 @@ use constant DEBUG => (exists $opt{d} ? 1 : 0);
 #=============================================================================
 
 BEGIN {
-    maybe_plan(238, 'SQL::Translator::Parser::XML::SQLFairy');
+    maybe_plan(undef, 'SQL::Translator::Parser::XML::SQLFairy');
 }
 
 my $testschema = "$Bin/data/xml/schema.xml";
@@ -235,6 +235,7 @@ schema_ok( $scma, {
             database_events     => 'insert',
             on_table            => 'Basic',
             action              => 'update modified=timestamp();',
+            scope               => 'row',
             extra => {
                 foo => "bar",
                 hello => "world",
@@ -247,6 +248,7 @@ schema_ok( $scma, {
             database_events     => 'insert,update',
             on_table            => 'Basic',
             action              => 'update modified2=timestamp();',
+            scope               => 'row',
             extra => {
                 hello => "aliens",
             },
@@ -269,3 +271,5 @@ schema_ok( $scma, {
     ],
 
 }); # end schema
+
+done_testing;

t/17sqlfxml-producer.t

@@ -193,7 +193,7 @@ $ans = <<EOXML;
   </tables>
   <views></views>
   <triggers>
-    <trigger name="foo_trigger" database_events="insert" on_table="Basic" perform_action_when="after" order="1">
+    <trigger name="foo_trigger" database_events="insert" on_table="Basic" perform_action_when="after" order="1" scope="row">
       <action>update modified=timestamp();</action>
       <extra hello="world" />
     </trigger>
@@ -222,6 +222,7 @@ EOXML
         database_events     => [$database_event],
         table               => $table,
         action              => $action,
+        scope               => 'row',
         extra               => { hello => "world" },
     ) or die $s->error;
 

t/23json.t

@@ -260,7 +260,8 @@ my $json = to_json(from_json(<<JSON), { canonical => 1, pretty => 1 });
             "name" : "pet_trig",
             "on_table" : "pet",
             "order" : "1",
-            "perform_action_when" : "after"
+            "perform_action_when" : "after",
+            "scope": "row"
          }
       },
       "views" : {