Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable tests make them pass #8

Open
JJ-Author opened this issue Feb 13, 2024 · 4 comments
Open

reenable tests make them pass #8

JJ-Author opened this issue Feb 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@JJ-Author
Copy link
Contributor

I disabled tests/test_databusclient.py because they fail and need fixing e.g. test_databusclient.py#L50
potentially also the tested routines need fixing

@JJ-Author JJ-Author added the bug Something isn't working label Feb 13, 2024
@JJ-Author JJ-Author changed the title reenable and pass download tests reenable tests make them pass Feb 14, 2024
@typhonshambo
Copy link

hi @JJ-Author I would like to work on this! can you provide bit of information regarding the tests.

@JJ-Author
Copy link
Contributor Author

JJ-Author commented Jun 25, 2024

see this commit, I fixed the download test code a little such that the download tests actually work
d3ca19c

but also skipped 2 tests using the following annotation
@pytest.mark.skip

since they fail.

task is to fix the test code and if needed the client code as well such that the tests are meaningful and pass.
not sure if this is a beginner friendly task since it requires deep knowledge about the databus its datamodel (that changed) and the Databus API.

@typhonshambo
Copy link

@JJ-Author Alright thanks for the context! May I know is there any docs available related to Databus API?

@JJ-Author
Copy link
Contributor Author

https://dev.databus.dbpedia.org/api/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants