Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break netbots_server.py into multiple files #97

Open
dbakewel opened this issue Jun 7, 2019 · 1 comment
Open

Break netbots_server.py into multiple files #97

dbakewel opened this issue Jun 7, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@dbakewel
Copy link
Owner

dbakewel commented Jun 7, 2019

Is your feature request related to a problem? Please describe.
netbots_server.py is over 1000 lines. It has become hard to read through.

Describe the solution you'd like
I propose moving the following from netbots_servers.py to their own files:

  • SrvData and argparse into netbots_srvdata.py
  • Message code into netbots_srvmsg.py
  • Step processing into netbots_srvstep.py (The step function should also be broken into multiple functions)

Describe alternatives you've considered
We could just leave it the way it is. There is also the option to change everything to objects. Then the there could be one file for each object. However, as long as robots and shells are the only things moving in the arena then objects do not add much value.

@dbakewel dbakewel added the enhancement New feature or request label Jun 7, 2019
@dbakewel dbakewel added this to the 3.0 milestone Jun 7, 2019
@mcstoer
Copy link
Contributor

mcstoer commented Jun 15, 2019

I think separating the code in the above fashion would work well, but where would the initializing game code go? (laying out jam zones, obstacles and starting positions) Would that be a part of netbots_srvstep.py or a separate file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants