New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: generate components with complex children for patternhub copy-code #2757

Merged

nmerget merged 25 commits into main from docs-generate-copy-code

Jul 8, 2024

Member

nmerget commented Jun 18, 2024 •

edited by mfranzke

Loading

Proposed changes

closes #2742
closes #2747
closes #3089

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (fix on existing components or architectural decisions)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

Further comments


          docs: generate components with complex children for patternhub copy-code

bff1cfa

nmerget requested review from mfranzke, dkolba and annsch as code owners

June 18, 2024 11:40

nmerget enabled auto-merge (squash)

June 18, 2024 11:40


          Merge branch 'main' of github.com:db-ui/mono into docs-generate-copy-…

0f7d8c7

…code

# Conflicts:
#	showcases/shared/drawer.json
#	showcases/shared/header.json
#	showcases/shared/navigation.json

github-actions bot added 📕documentation 🏘components 📺showcases labels

github-advanced-security bot found potential problems

View reviewed changes

showcases/patternhub/scripts/utils.js Dismissed Show dismissed Hide dismissed


          fix: make exampleProps optional

d67aa6e

mfranzke reviewed

View reviewed changes

showcases/shared/tag.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/shared/tag.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/shared/notification.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/shared/notification.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/shared/notification.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/shared/accordion.json Outdated Show resolved Hide resolved

nmerget and others added 10 commits

June 19, 2024 08:28


          Update showcases/shared/tag.json

db9cdb8

Co-authored-by: Maximilian Franzke <[email protected]>


          Update showcases/shared/tag.json

241f090

Co-authored-by: Maximilian Franzke <[email protected]>


          Update showcases/shared/notification.json

cefab18

Co-authored-by: Maximilian Franzke <[email protected]>


          Update showcases/shared/notification.json

ad8bee4

Co-authored-by: Maximilian Franzke <[email protected]>


          Update showcases/shared/notification.json

fef57c3

Co-authored-by: Maximilian Franzke <[email protected]>


          chore: update specs for accordion showcase

3ea7f4d


          Merge remote-tracking branch 'origin/docs-generate-copy-code' into do…

f433829

…cs-generate-copy-code


          fix: issue with initialSelectedIndex for Tabs


          Merge branch 'main' into docs-generate-copy-code

8e9e9c6


          Merge branch 'main' into docs-generate-copy-code

77df4c9

nmerget requested a review from mfranzke

June 24, 2024 12:47


          Merge branch 'main' of github.com:db-ui/mono into docs-generate-copy-…

24bfd1c

…code

# Conflicts:
#	showcases/angular-showcase/src/app/components/tooltip/tooltip.component.html
#	showcases/patternhub/scripts/get-code-files.js
#	showcases/vue-showcase/src/components/tooltip/Tooltip.vue

nmerget requested a review from bruno-sch as a code owner

June 24, 2024 12:49

nmerget and others added 4 commits

June 25, 2024 10:26


          Merge branch 'main' into docs-generate-copy-code

19baf1b


          fix: linting issue

015e5f0


          Merge branch 'main' into docs-generate-copy-code

4c7b979


          Merge branch 'main' into docs-generate-copy-code

d61f6c3

mfranzke reviewed

View reviewed changes

packages/components/src/components/tabs/tabs.lite.tsx Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/patternhub/scripts/utils.js Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

showcases/patternhub/scripts/utils.js Outdated Show resolved Hide resolved

mfranzke previously approved these changes

View reviewed changes


          Merge branch 'main' into docs-generate-copy-code

bb72e55

mfranzke self-assigned this

mfranzke added this to the v0.3.0 milestone


          Update showcases/patternhub/scripts/utils.js

36213d2

Co-authored-by: Maximilian Franzke <[email protected]>

nmerget dismissed mfranzke’s stale review via

36213d2

July 8, 2024 06:15

nmerget and others added 2 commits

July 8, 2024 08:26


          Update showcases/patternhub/scripts/utils.js

Co-authored-by: Maximilian Franzke <[email protected]>


          Update packages/components/src/components/tabs/tabs.lite.tsx

ea54731

Co-authored-by: Maximilian Franzke <[email protected]>

nmerget requested a review from mfranzke

July 8, 2024 06:26

mfranzke approved these changes

View reviewed changes

nmerget and others added 3 commits

July 8, 2024 08:46


          Merge branch 'main' into docs-generate-copy-code

3d5b199


          Merge branch 'main' into docs-generate-copy-code

dbadfa6


          Merge branch 'main' into docs-generate-copy-code

c17c20d

nmerget merged commit a867b08 into main

50 checks passed

nmerget deleted the docs-generate-copy-code branch

July 8, 2024 08:41

nmerget mentioned this pull request

Docs: Probably not providing code samples within the description files #1565

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mfranzke mfranzke approved these changes

dkolba Awaiting requested review from dkolba dkolba is a code owner

annsch Awaiting requested review from annsch annsch is a code owner

bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Labels

🏘components 📕documentation 📺showcases