Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBTag: provide overflow (tbd.) #2734

Closed
2 of 7 tasks
annsch opened this issue Jun 10, 2024 · 5 comments
Closed
2 of 7 tasks

DBTag: provide overflow (tbd.) #2734

annsch opened this issue Jun 10, 2024 · 5 comments
Labels
👩‍👧‍👦community feedback Feedback from community ❓question Further information is requested

Comments

@annsch
Copy link
Collaborator

annsch commented Jun 10, 2024

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

DBTag component can be displayed smaller than its containing text. In this case the inner text should not overflow outside of its parent div. Could you enable overflow: hidden or inherit for this component?

Bildschirmfoto 2024-06-10 um 14 09 42

Expected Behaviour

Text should not overflow outside when using DBTag

Bildschirmfoto 2024-06-10 um 14 11 04

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

@mfranzke
Copy link
Member

mfranzke commented Jun 10, 2024

@annsch thanks for your feedback. What's the use case for text being cropped in this case? It seems like that with some short words or phrases like these, even ellipsis wouldn't work, so it would be a bad UX for anybody (except screenreader, somehow).

@annsch
Copy link
Collaborator Author

annsch commented Jun 11, 2024

@mfranzke We use the DBTag on a Timeline Component. This component's size is measured by the current zoom and so it can be downscaled on its y-axis...

@nmerget
Copy link
Member

nmerget commented Jun 21, 2024

https://db-ui.github.io/mono/review/main/components/data-display/tag/overview?page=overflow <- there is an overflow property

@nmerget nmerget added ❓question Further information is requested 👩‍👧‍👦community feedback Feedback from community labels Jun 21, 2024
@annsch
Copy link
Collaborator Author

annsch commented Jul 9, 2024

did not see this property

@annsch annsch closed this as completed Jul 9, 2024
@mfranzke
Copy link
Member

mfranzke commented Jul 9, 2024

did not see this property

No problem, that's my job (or @nmerget's).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍👧‍👦community feedback Feedback from community ❓question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants