Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to Add Support for Gitee in Git Provider or More Customization Options #1341

Closed
TS35 opened this issue Nov 15, 2024 · 24 comments · Fixed by #1409
Closed

Suggestion to Add Support for Gitee in Git Provider or More Customization Options #1341

TS35 opened this issue Nov 15, 2024 · 24 comments · Fixed by #1409
Labels
enhancement New feature or request ⚔️ Quest Tracks quest-bot quests

Comments

@TS35
Copy link

TS35 commented Nov 15, 2024

Hello, could you add support for Gitee in the git-providers configuration for Daytona? Alternatively, it would be great if future versions of Daytona could include more customizable options for git-provider, similar to how the Server in Daytona allows for some customization through modifications to the config.json file.

@TS35 TS35 added the enhancement New feature or request label Nov 15, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Nov 15, 2024

Hi @TS35,

We're definitely committed to adding support for any available git providers.

If you're up for it, you can implement it through a PR yourself. You can check implementations for existing providers here.

Alternatively, it would be great if future versions of Daytona could include more customizable options for git-provider, similar to how the Server in Daytona allows for some customization through modifications to the config.json file.

What do you mean by this? Are there some options that are missing from daytona git-provider add?

@TS35
Copy link
Author

TS35 commented Nov 15, 2024

Hi @TS35,

We're definitely committed to adding support for any available git providers.

If you're up for it, you can implement it through a PR yourself. You can check implementations for existing providers here.

Alternatively, it would be great if future versions of Daytona could include more customizable options for git-provider, similar to how the Server in Daytona allows for some customization through modifications to the config.json file.

What do you mean by this? Are there some options that are missing from daytona git-provider add?

Thank you for your response. What I meant is that when I tried to use Gitee in Daytona, I selected GitLab Self-managed in the git-provider options. Daytona then prompted me to enter the Self-managed API URL, and I noticed that the provided example was http://gitlab-host/api/v4/, while the API URL provided by Gitee is https://gitee.com/api/v5/. Therefore, I wondered if it would be possible to support Gitee in Daytona through some custom settings. However, I understand that this may not be as simple as the Server in Daytona, where users can achieve it just by making some straightforward changes to the config.json, right? This would likely involve modifying Daytona's source code.

@Tpuljak
Copy link
Member

Tpuljak commented Nov 15, 2024

This would likely involve modifying Daytona's source code.

That's true. We need to implement a new git provider (e.g. https://github.com/daytonaio/daytona/blob/main/pkg/gitprovider/azure-devops.go) for the Gitee API. You would then be able to select Gitee in the daytona git-provider add UI.

@Tpuljak
Copy link
Member

Tpuljak commented Nov 25, 2024

@quest-bot stash 100

Copy link

quest-bot bot commented Nov 25, 2024

New Quest! image New Quest!

A new Quest has been launched in @daytonaio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 100 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1341 to link your PR to this Quest.

Questions? Check out the docs.


👉 If no one is assigned to the issue, you are welcome to embark on the quest and tackle it without confirmation from us. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Nov 25, 2024
@katungi
Copy link

katungi commented Nov 25, 2024

Hey @Tpuljak , this looks like a good challenge, is anyone working on it?
If not, I can take a swing on it.

@Tpuljak
Copy link
Member

Tpuljak commented Nov 25, 2024

@katungi of course, go for it!

@katungi
Copy link

katungi commented Nov 25, 2024

@quest-bot embark

Copy link

quest-bot bot commented Nov 25, 2024

@katungi has embarked on their Quest. 🗡

  • @katungi has been on GitHub since 2017.
  • They have merged 32 public PRs in that time.
  • Their swords are blessed with JavaScript and TypeScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@naaa760
Copy link

naaa760 commented Nov 26, 2024

@quest-bot embark

Copy link

quest-bot bot commented Nov 26, 2024

@naaa760 has embarked on their Quest. 🗡

  • @naaa760 has been on GitHub since 2024.
  • They have merged 4 public PRs in that time.
  • Their swords are blessed with JavaScript and TypeScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@naaa760
Copy link

naaa760 commented Nov 26, 2024

Hello!
I would like to work on this issue!

@Tpuljak
Copy link
Member

Tpuljak commented Nov 26, 2024

Hello!

I would like to work on this issue!

Hi @naaa760,

I can see that you're embarking on a lot of issues.

I suggest that you focus on one issue at a time and embark only on those that you're actively working on.

Embarking on an issue doesn't mean that you have the exclusive right to work on it and earn the bounty.

@Sourabh7iwari
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Nov 30, 2024

@Sourabh7iwari has embarked on their Quest. 🗡

  • @Sourabh7iwari has been on GitHub since 2020.
  • They have merged 4 public PRs in that time.
  • Their swords are blessed with Python and CSS magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Sourabh7iwari
Copy link
Contributor

@Tpuljak hello sir can i submit PR on it?

@Tpuljak
Copy link
Member

Tpuljak commented Nov 30, 2024

@Tpuljak hello sir can i submit PR on it?

@Sourabh7iwari of course. If no one is assigned to the issue, feel free to work on it and submit a PR.

Copy link

quest-bot bot commented Nov 30, 2024

🧚 @Sourabh7iwari has submitted PR #1403 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @naaa760
@katungi

Questions? Check out the docs.

@Sourabh7iwari
Copy link
Contributor

@Tpuljak Sir, I have submitted the pull request and am now waiting. Is there any further action required from my side for successful merging, or is there something missing in my changes that needs attention for Gitee support? Since this is my first time, I would appreciate any assistance.
thanks

@Tpuljak
Copy link
Member

Tpuljak commented Dec 2, 2024

@Tpuljak Sir, I have submitted the pull request and am now waiting. Is there any further action required from my side for successful merging, or is there something missing in my changes that needs attention for Gitee support? Since this is my first time, I would appreciate any assistance. thanks

Thanks @Sourabh7iwari! @mojafa will take a look at the PR as soon as possible.

@tarunrajput
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Dec 3, 2024

@tarunrajput has embarked on their Quest. 🗡

  • @tarunrajput has been on GitHub since 2017.
  • They have merged 91 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Copy link

quest-bot bot commented Dec 3, 2024

🧚 @tarunrajput has submitted PR #1409 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @naaa760
@katungi
@Sourabh7iwari

Questions? Check out the docs.

Copy link

quest-bot bot commented Dec 5, 2024

Quest solved! image Quest solved!

Congratulations! Your efforts have paid off. A PR that solves this Quest has been merged.


@tarunrajput, you have been victorious in Quest #1341 🗡

💰 To claim your $100 reward follow instructions here

🧚 Thanks to all bold adventurers for attempting this quest! Sign-up to Quira.sh to access more exciting Quests like this one ⚔️

This Quest is now closed ✨

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants