Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressing ? for help in list views have leftover after use #1287

Closed
divanshu-go opened this issue Oct 24, 2024 · 15 comments
Closed

pressing ? for help in list views have leftover after use #1287

divanshu-go opened this issue Oct 24, 2024 · 15 comments
Labels
bug Something isn't working never stale An issue that never goes stale ⚔️ Quest Tracks quest-bot quests

Comments

@divanshu-go
Copy link

Describe the bug
when any listview is shown it has ? at the bottom for showing full help but after pressing ? the full help is shown but when we close the help after pressing ? , it shows leftover of previews help.

To Reproduce
Steps to reproduce the behavior:

  1. run daytona create
  2. press ? on your keyboard
  3. you will see that full help appears
  4. See that after pressing the ? again the short help is shown , which is correct but leftovers of previous help will be there

Expected behavior
there should be no leftover of previous help after the new help footer is being shown

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: fedora 40
  • Daytona Version: 0.41.0
@divanshu-go divanshu-go added the bug Something isn't working label Oct 24, 2024
@Tpuljak Tpuljak added the never stale An issue that never goes stale label Oct 24, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Nov 25, 2024

@quest-bot stash 40

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Nov 25, 2024
Copy link

quest-bot bot commented Nov 25, 2024

New Quest! image New Quest!

A new Quest has been launched in @daytonaio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 40 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1287 to link your PR to this Quest.

Questions? Check out the docs.


👉 If no one is assigned to the issue, you are welcome to embark on the quest and tackle it without confirmation from us. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

@Ximax80
Copy link

Ximax80 commented Nov 26, 2024

@quest-bot embark

Copy link

quest-bot bot commented Nov 26, 2024

@Ximax80 has embarked on their Quest. 🗡

  • @Ximax80 has been on GitHub since 2024.
  • They have merged 0 public PRs in that time.
  • Their swords are blessed with Go and Shell magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Ximax80 added a commit to Ximax80/daytona that referenced this issue Nov 26, 2024
Copy link

quest-bot bot commented Nov 26, 2024

🧚 @Ximax80 has submitted PR #1376 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

@calebjubal
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 30, 2024

@calebjubal has embarked on their Quest. 🗡

  • @calebjubal has been on GitHub since 2021.
  • They have merged 7 public PRs in that time.
  • Their swords are blessed with JavaScript and Python magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Ujj1225
Copy link
Contributor

Ujj1225 commented Dec 2, 2024

@divanshu-go assign me this issue

@Tpuljak
Copy link
Member

Tpuljak commented Dec 2, 2024

@divanshu-go assign me this issue

@Ujj1225 no need to get assigned. You can work on the issue and submit a PR

@tarunrajput
Copy link
Contributor

@Tpuljak, I am no longer able to reproduce this. Could you pls check at your end?

@Tpuljak
Copy link
Member

Tpuljak commented Dec 5, 2024

@mojafa please check this

@RS-labhub
Copy link
Contributor

I'm also not able to reproduce it.

Check the attachment below:
https://github.com/user-attachments/assets/1ef4879c-1bf4-4bb5-9219-40f9c5e51ad2

@mojafa
Copy link
Collaborator

mojafa commented Dec 5, 2024

On presssing ? once
Screenshot 2024-12-05 at 15 44 15

@tarunrajput @Tpuljak
On presssing ? second time, no left overs on my end as well

Screenshot 2024-12-05 at 15 44 44

@Tpuljak
Copy link
Member

Tpuljak commented Dec 5, 2024

Thanks for the investigation. Closing this issue then.

@Tpuljak Tpuljak closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
Copy link

quest-bot bot commented Dec 5, 2024

Swords down 🗡

❌ Issue #1287 and it's Quest have been closed by @daytonaio

Head over to https://quine.sh/quests/solver to find other active Quests ⚔️

Questions? Check out the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale An issue that never goes stale ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

No branches or pull requests

8 participants