Skip to content

Commit 81e8f30

Browse files
committed
Trace the completion of a dispatch-sync with a new :sync op-type
For day8/re-frame-10x#263
1 parent c97b9e9 commit 81e8f30

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

docs/releases/2023.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66

77
> The re-frame [Clojars page](https://clojars.org/re-frame/) contains dependency coordinates for Maven/deps/Lein.
88
9+
## 1.4.1 (2023-12-07)
10+
11+
#### Added
12+
13+
- `dispatch-sync` now emits a `:sync` trace to indicate when it has finished. See [re-frame-10x#165](https://github.com/day8/re-frame-10x/issues/165)
14+
915
## 1.4.0 (2023-11-02)
1016

1117
#### Breaking
@@ -14,7 +20,7 @@
1420

1521
#### Added
1622
- Interceptors now have an optional `:comment` key. It's a no-op.
17-
- `re-frame.std-interceptors/path` now remembers the path it uses in a `:comment`. ((re-frame-10x#165)[https://github.com/day8/re-frame-10x/issues/165])
23+
- `re-frame.std-interceptors/path` now remembers the path it uses in a `:comment`. ([re-frame-10x#165](https://github.com/day8/re-frame-10x/issues/165))
1824
- `re-frame.alpha` namespace, for testing proposed features (see [flows](https://github.com/day8/re-frame/discussions/795) and [polymorphic subscriptions](https://github.com/day8/re-frame/issues/680#issuecomment-1676487563))
1925

2026
#### Changed

src/re_frame/router.cljc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,4 +236,5 @@
236236
[event-v]
237237
(handle event-v)
238238
(-call-post-event-callbacks event-queue event-v) ;; slightly ugly hack. Run the registered post event callbacks.
239+
(trace/with-trace {:op-type :sync})
239240
nil) ;; Ensure nil return. See https://github.com/day8/re-frame/wiki/Beware-Returning-False

0 commit comments

Comments
 (0)