Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

create sub-pages inside tabs? #36

Open
codeclinic opened this issue Aug 13, 2020 · 5 comments
Open

create sub-pages inside tabs? #36

codeclinic opened this issue Aug 13, 2020 · 5 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@codeclinic
Copy link
Collaborator

Or some kind of pagination, so if I have a lot of options it would be easier to navigate through them?
So far I've been able to create a single-level tabs without any nesting, but that's only enough for the most basic menu pages.
Maybe it's not too hard to extend some classes and create such functionality myself? Any advice on how should I proceed with it?

Ref: gambitph#322

@codeclinic codeclinic added enhancement New feature or request question Further information is requested labels Aug 13, 2020
@codeclinic
Copy link
Collaborator Author

@davidsneighbour We already have tabs and sub-menus, does this add any real advantages? Or are the advantages worth the diversion of resources to create this?

@davidsneighbour
Copy link
Owner

If I understand that correctly then we want tabs inside of tabs - or a usable alternative to that like a step1-2-3 menu. That should be doable. The only limit would be the amount of options that is sent via POST to the server, there is a point where this will be too much data, so the sub-tabs should be decoupled from each other. I'll have a look at it after 2.0.0

@codeclinic
Copy link
Collaborator Author

I think the aim is for pagination rather than tabs if I'm interpreting this correctly.

So you might have a tab with lot of options, and rather than have a really long page to scroll down, you would have pagination within the existing tab. Personally, I'm inclined to say that this is bad from a usability perspective since you'd potentially have a setting on the 5th page of the third tab thats under submenu 7. etc

I think if someone needs to add pagination they probably need to rethink their groupings across tabs and submenus. I have a plugin with 5 extensions that add functionality and more than 100 settings. I'm able to do everything that I need without too much effort spent on organising my tabs properly. My only "complaint" is that tabs can start to look messy when you have a larger number of them.

Maybe we should actually just look at reviewing layouts (tabs, submenus and option groupings/sections) in general with v2?

@davidsneighbour
Copy link
Owner

Maybe we should actually just look at reviewing layouts (tabs, sub menus and option groupings/sections) in general with v2?

Maybe with v2.1? ;) I would prefer to have 2.0 being the complete rebranding and some smaller fixes only so we don't block having our first official version soon. And having a major increment seems to be the "proper" way to detach ourselves from Titan Framework for me. I did not think/plan to have a v1.13 or something like that...

Pagination might be possible with some javascripts that collect the divs of options and group/page them by a settable counter (one page per 10 options). That might keep this "feature" out of the core and could be added as a hook or filter function somewhere down the road in some kind of "cookbook"? It feels like a hack, but possible to implement.

I think it's a usability issue in the long run. Separating options/groups without thought just by a count might be un-intuitive for the end-user.

I know themes that use the Redux Framework and have literally unscrollable long tab-lists with option pages which is counter-intuitive too...

This needs some research IMHO.

Selection_024

@codeclinic
Copy link
Collaborator Author

Maybe with v2.1? ;) I would prefer to have 2.0 being the complete rebranding and some smaller fixes only so we don't block having our first official version soon. And having a major increment seems to be the "proper" way to detach ourselves from Titan Framework for me. I did not think/plan to have a v1.13 or something like that...

Sure. I wrongly assumed our first release would be v1 and the next big one would be v2. Eitherway, my intention was to say that this is something for further down the line if at all. Personally, I don't see the benefits in implementing it. But, we can leave this open for now to collect feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants