Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/fillstruct: selection by line #3

Closed
davidrjenni opened this issue Sep 18, 2017 · 0 comments
Closed

cmd/fillstruct: selection by line #3

davidrjenni opened this issue Sep 18, 2017 · 0 comments
Assignees
@davidrjenni
Labels
enhancement

Comments

@davidrjenni
Copy link
Owner

Incorporate the suggestion made in a comment by @fatih (fatih/vim-go#1443):

This looks good. Wish it could work when you put it everywhere on the line instead of putting it on the struct literal. I think this is something @davidrjenni can fix though. Adding him if he can chime on that.
@davidrjenni davidrjenni self-assigned this Sep 18, 2017
davidrjenni added a commit that referenced this issue Oct 8, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
37a9b6b 
Fixes #3.
@davidrjenni davidrjenni mentioned this issue Oct 8, 2017
Merged
davidrjenni added a commit that referenced this issue Oct 10, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
d01ca2e 
Fixes #3.
davidrjenni added a commit that referenced this issue Oct 13, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
fbb6762 
Fixes #3.
davidrjenni added a commit that referenced this issue Oct 13, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
e7731cf 
Fixes #3.
davidrjenni added a commit that referenced this issue Oct 19, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
929d207 
The new command line parameter -line can be used to specify the
position of one or more struct literals by providing the corresponding
line number.

If both parameters, -offset and -line, are provided, then the tool
first uses the more specific offset information. If there was no
struct literal found at the given offset, then the line information is
used.

If more than one struct literal was found, code to fill all of them is
generated. The output is a JSON array with the elements in reverse
order of their occurence.

Fixes #3.
davidrjenni added a commit that referenced this issue Dec 13, 2017
@davidrjenni
cmd/fillstruct: add option to select by line number.
4081440 
The new command line parameter -line can be used to specify the
position of one or more struct literals by providing the corresponding
line number.

If both parameters, -offset and -line, are provided, then the tool
first uses the more specific offset information. If there was no
struct literal found at the given offset, then the line information is
used.

If more than one struct literal was found, code to fill all of them is
generated. The output is a JSON array with the elements in reverse
order of their occurence.

Fixes #3.
davidrjenni pushed a commit that referenced this issue Dec 13, 2017
cmd/fillstruct: add option to select by line number. (#8)
cdebcee 
The new command line parameter -line can be used to specify the
position of one or more struct literals by providing the corresponding
line number.

If both parameters, -offset and -line, are provided, then the tool
first uses the more specific offset information. If there was no
struct literal found at the given offset, then the line information is
used.

If more than one struct literal was found, code to fill all of them is
generated. The output is a JSON array with the elements in reverse
order of their occurence.

Fixes #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidrjenni davidrjenni

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidrjenni