From c733aa0bf24d43376269d05d67bfc22208f2148b Mon Sep 17 00:00:00 2001 From: David LJ Date: Mon, 8 Jul 2024 23:43:32 +0200 Subject: [PATCH] ci: remove unit test reporter --- .ci/Makefile | 2 +- .github/workflows/main.yml | 2 -- .github/workflows/reusable-test.yml | 12 ------------ karma.conf.js | 6 ------ package.json | 1 - pnpm-lock.yaml | 21 --------------------- 6 files changed, 1 insertion(+), 43 deletions(-) diff --git a/.ci/Makefile b/.ci/Makefile index 8b039a2f..5b65ad6f 100644 --- a/.ci/Makefile +++ b/.ci/Makefile @@ -20,4 +20,4 @@ unit-test: cp ../src/test/mocks/release.json .. pnpm run test:unit --browsers=ChromeHeadless \ - --no-watch --no-progress --reporters junit,progress --code-coverage + --no-watch --no-progress --reporters progress --code-coverage diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index dd5b3ca8..c87adcf6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -18,8 +18,6 @@ jobs: test: name: Test uses: ./.github/workflows/reusable-test.yml - permissions: - checks: write secrets: codecov-token: ${{ secrets.CODECOV_TOKEN }} lint: diff --git a/.github/workflows/reusable-test.yml b/.github/workflows/reusable-test.yml index 24ed89ab..794a5cfe 100644 --- a/.github/workflows/reusable-test.yml +++ b/.github/workflows/reusable-test.yml @@ -12,11 +12,6 @@ on: description: Token to use to upload coverage to Codecov. Can be empty for forks https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/ required: true -# Add those permissions if reporting test results -# https://github.com/dorny/test-reporter/issues/229 -# permissions: -# checks: write - env: COVERAGE_ARTIFACT_NAME_PREFIX: coverage- COVERAGE_DIR: coverage @@ -50,13 +45,6 @@ jobs: uses: ./.github/actions/setup - name: Run tests run: cd .ci && make unit-test - - name: Report test results (as status check) - uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5 # v1 - if: (success() || failure()) && github.ref == 'refs/heads/main' - with: - name: Test results - path: '*.xml' - reporter: java-junit - name: Upload coverage results uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4 with: diff --git a/karma.conf.js b/karma.conf.js index f73bb16f..bc609cde 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -9,7 +9,6 @@ module.exports = function (config) { require('karma-jasmine'), require('karma-chrome-launcher'), require('karma-jasmine-html-reporter'), - require('karma-junit-reporter'), require('karma-coverage'), require('@angular-devkit/build-angular/plugins/karma'), ], @@ -44,10 +43,5 @@ module.exports = function (config) { reporters: ['progress', 'kjhtml'], browsers: ['Chrome'], restartOnFileChange: true, - // https://www.npmjs.com/package/karma-junit-reporter#configuration - junitReporter: { - useBrowserName: false, - outputFile: 'junit-test.xml', - }, }) } diff --git a/package.json b/package.json index 62682559..d20d932c 100644 --- a/package.json +++ b/package.json @@ -110,7 +110,6 @@ "karma-coverage": "2.2.1", "karma-jasmine": "5.1.0", "karma-jasmine-html-reporter": "2.1.0", - "karma-junit-reporter": "2.0.1", "lint-staged": "15.2.7", "liquidjs": "10.14.0", "ng-mocks": "14.13.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 57932c6d..40fc7499 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -192,9 +192,6 @@ importers: karma-jasmine-html-reporter: specifier: 2.1.0 version: 2.1.0(jasmine-core@5.1.2)(karma-jasmine@5.1.0(karma@6.4.3))(karma@6.4.3) - karma-junit-reporter: - specifier: 2.0.1 - version: 2.0.1(karma@6.4.3) lint-staged: specifier: 15.2.7 version: 15.2.7 @@ -4940,12 +4937,6 @@ packages: peerDependencies: karma: ^6.0.0 - karma-junit-reporter@2.0.1: - resolution: {integrity: sha512-VtcGfE0JE4OE1wn0LK8xxDKaTP7slN8DO3I+4xg6gAi1IoAHAXOJ1V9G/y45Xg6sxdxPOR3THCFtDlAfBo9Afw==} - engines: {node: '>= 8'} - peerDependencies: - karma: '>=0.9' - karma-source-map-support@1.4.0: resolution: {integrity: sha512-RsBECncGO17KAoJCYXjv+ckIz+Ii9NCi+9enk+rq6XC81ezYkb4/RHE6CTXdA7IOJqoF3wcaLfVG0CPmE5ca6A==} @@ -7417,10 +7408,6 @@ packages: resolution: {integrity: sha512-sID0rrVCqkVNUn8t6xuv9+6FViXjUVXq8H5rWOH2rz9fDNQEd4g0EA2XlcEdJXRz5BMEn4O1pJFdT+z4YHhoWw==} engines: {node: '>= 6'} - xmlbuilder@12.0.0: - resolution: {integrity: sha512-lMo8DJ8u6JRWp0/Y4XLa/atVDr75H9litKlb2E5j3V3MesoL50EBgZDWoLT3F/LztVnG67GjPXLZpqcky/UMnQ==} - engines: {node: '>=6.0'} - xmlhttprequest-ssl@2.0.0: resolution: {integrity: sha512-QKxVRxiRACQcVuQEYFsI1hhkrMlrXHPegbbd1yn9UHOmRxY+si12nQYzri3vbzt8VdTTRviqcKxcyllFas5z2A==} engines: {node: '>=0.4.0'} @@ -13420,12 +13407,6 @@ snapshots: jasmine-core: 4.6.0 karma: 6.4.3 - karma-junit-reporter@2.0.1(karma@6.4.3): - dependencies: - karma: 6.4.3 - path-is-absolute: 1.0.1 - xmlbuilder: 12.0.0 - karma-source-map-support@1.4.0: dependencies: source-map-support: 0.5.21 @@ -16158,8 +16139,6 @@ snapshots: xhr2@0.2.1: {} - xmlbuilder@12.0.0: {} - xmlhttprequest-ssl@2.0.0: {} xtend@4.0.2: {}