Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing find_one_and_update() #90

Open
utf opened this issue Dec 10, 2023 · 1 comment
Open

Implementing find_one_and_update() #90

utf opened this issue Dec 10, 2023 · 1 comment

Comments

@utf
Copy link

utf commented Dec 10, 2023

Firstly, thank you for your work developing this package - I've found it very useful in my projects.

I've run into an issue where I need to use the find_one_and_update function of pymongo. Is there any plan to implement this feature in montydb? If not, would you be willing to give me any pointers as to how I could implement this myself in a PR?

@davidlatwe
Copy link
Owner

Hey @utf , thanks!

Sorry for being late, I missed this one. Yeah, PR would be very welcome! For starter, you can have a look at Collection.update_one and find_one, see if we can combine them. 🤔

I would first adding some test cases, like here, to make sure we get it right. For running tests, you can have a look at this section

Please do let me know if you have any problems. 😄

@davidlatwe davidlatwe changed the title Implementing find_out_and_update() Implementing find_one_and_update() Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants