Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import adapters correctly #18

Open
UserGalileo opened this issue Jun 21, 2019 · 2 comments
Open

Cannot import adapters correctly #18

UserGalileo opened this issue Jun 21, 2019 · 2 comments

Comments

@UserGalileo
Copy link

Hi,
I'm working in a TypeScript project with webpack.

I stumbled across this post [https://css-tricks.com/animating-layouts-with-the-flip-technique/] and decided to try your library. In your example, you use this import syntax:

import Flipping from 'flipping/adapters/web';

Unfortunately, this doesn't work (I'm using the latest version, 1.1.0). The only way I found for importing the Web Adapter is this, which feels unnatural:

import Flipping from 'flipping/lib/adapters/web';

This works, but the editor complains about that file not having a default export.

I think that with some minor changes to your project structure/configuration we should be able to use the syntax you used in that article, let me know if I'm doing something wrong :) Cheers!

@davidkpiano
Copy link
Owner

I'd be happy to accept a PR. With Flipping V2, adapters are going away (because it'll get a lot simpler).

@UserGalileo
Copy link
Author

Cool, any info about V2? How will it be structured? Are adapters going to be a sort of "plugin"? Any idea about the release date? (if it's soon, we could skip the PR and wait for the V2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants