[Help]: Missing destroyHeight from AutoHeight() options

[zaaakher]

Summary

Hi @davidjerleke, hope you're doing well.

I update dependencies routinely in some of my projects (Hawa in this case) and it seems the latest version of embla-carousel-auto-height doesn't have a destroyHeight property in the options of AutoHeight function.

I couldn't find any mention in the changelog/release descriptions. Was it replaced with something else?

Thank you for the continuous work you do for this wonderful package 🌹

If applicable, which variants of Embla Carousel are relevant to this question?

• embla-carousel-auto-height

[zaaakher]

Ok after a little digging I found the moment it was removed 👇

8eca652#diff-9b492d4efffa04663108927b0281a3403b6426079070f8bb9732cc274abdba41

[davidjerleke]

Hi @zaaakher,

Nice to hear from you again 🙂. You're right, it was on my todo for v8.0.0 but somehow I forgot to remove it. Sorry for the inconvenience. The new behavior is much better and works like this:

• It removes the height style when it destroys/unmounts.
• And if there are no additional styles, it removes the inline style property from the container.

No need to set destroyHeight anymore. A breaking change not related to a major version doesn't happen often I promise.

Best,
David

[zaaakher]

Hey brother 👋,

Sounds excellent, well done as always 👍!

Don't worry about it, I kinda wanted to put this discussion out there so that other people can find the answer if they ever had the same question.

If you think it's not enough and other devs might create issues regarding the missing destroyHeights. Then perhaps we can add a callout in the docs saying something like:

Note

As of v8.0.0 the option destroyHeight is deprecated and not needed anymore. See this discussion for more info

Let me know if you'd like that and I will create a PR for it :)

However, feel free to @ me anytime you need assistance in anything and I will try to do my best. 👌

[davidjerleke]

I kinda wanted to put this discussion out there so that other people can find the answer if they ever had the same question.

@zaaakher that's great and very helpful 👍.

If you think it's not enough and other devs might create issues regarding the missing destroyHeights. Then perhaps we can add a callout in the docs

Good idea!. Let's see if this discussion is enough or if it will cause a lot of trouble.

However, feel free to @ me anytime you need assistance in anything and I will try to do my best. 👌

Thanks for supporting this project! Will do 🙂.