-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add ALB Events to the supported list. #91
Comments
There's already a PR in place for this #85, I'm just waiting for a couple of changes before merging it. |
Hi, PR #85 was closed but I'm not sure if ALB is supported now or not. |
Hi, I tried this package with an internal ALB, and it doesn't work. Could you please add support to ALB events ? |
@davidgf : Is this project still maintained ? |
@JeremieDemarchez due to personal and professional reasons, I don't have time to implement or review changes. I'm also reluctant to merge anything that I haven't tested thoroughly, specially taking into account that this plugin handles deployments. |
@davidgf I can totally understand the lack of time, I'm in the same situation. |
Please add ALB events as well to the list of supported events.
Appreciate it!
Any other comments?
In the current list of events supported by serverless-plugin-canary-deployments, ALB events are not supported. With Lambdas being exposed over ALB (instead of API Gateway) is becoming a popular pattern since AWS announced it 18 months ago, it makes a perfect puzzle piece to address.
Looking forward to what you think!
The text was updated successfully, but these errors were encountered: