Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add ALB Events to the supported list. #91

Open
ramgrandhi opened this issue Aug 1, 2020 · 7 comments
Open

Please add ALB Events to the supported list. #91

ramgrandhi opened this issue Aug 1, 2020 · 7 comments

Comments

@ramgrandhi
Copy link

Please add ALB events as well to the list of supported events.

Appreciate it!

Any other comments?

In the current list of events supported by serverless-plugin-canary-deployments, ALB events are not supported. With Lambdas being exposed over ALB (instead of API Gateway) is becoming a popular pattern since AWS announced it 18 months ago, it makes a perfect puzzle piece to address.

Looking forward to what you think!

@davidgf
Copy link
Owner

davidgf commented Aug 11, 2020

There's already a PR in place for this #85, I'm just waiting for a couple of changes before merging it.

@hlhl040
Copy link

hlhl040 commented Sep 1, 2021

Hi, PR #85 was closed but I'm not sure if ALB is supported now or not.

@JeremieDemarchez
Copy link

JeremieDemarchez commented Nov 2, 2023

Hi,

I tried this package with an internal ALB, and it doesn't work.
The ALB Target Group use the $LATEST version instead of the Alias, but the resource policy that allows the ALB to instantiate the lambda is on the Alias (and not anymore on the $LATEST version, so it breaks the configuration).

Could you please add support to ALB events ?

@JeremieDemarchez
Copy link

@davidgf : Is this project still maintained ?

@davidgf
Copy link
Owner

davidgf commented Nov 14, 2023

@JeremieDemarchez due to personal and professional reasons, I don't have time to implement or review changes. I'm also reluctant to merge anything that I haven't tested thoroughly, specially taking into account that this plugin handles deployments.
Having said that, this is an open source project, and you are free to take the code and modify it as you see fit.

@JeremieDemarchez
Copy link

@davidgf I can totally understand the lack of time, I'm in the same situation.
Thank you for confirming that it is no longer actively maintained.
Sorry if you took it as a reproach, it was just a question.
Good luck.

@khvn26
Copy link

khvn26 commented Jan 8, 2024

Hi everyone, we have added ElasticLoadBalancingV2 TargetGroups support to our fork and published it to npm.

We also solved #94 and bumped a bunch of dependencies.

You can try npm i @flagsmith/serverless-plugin-canary-deployments and tell us what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants