Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Test failed on Duplicate plugin #147

Open
gustawdaniel opened this issue Aug 30, 2020 · 4 comments
Open

Test failed on Duplicate plugin #147

gustawdaniel opened this issue Aug 30, 2020 · 4 comments

Comments

@gustawdaniel
Copy link
Contributor

Zrzut ekranu z 2020-08-30 10-12-31

test: hello is loaded

How to reproduce:

  1. Generate project
  2. Install packages
  3. Run tests
@gustawdaniel
Copy link
Contributor Author

There are two problems:

  1. plugins for hooks should be named
  2. onError plugin in the example should have 4 arguments in agreeing to docs:

https://www.fastify.io/docs/v2.13.x/Hooks/#onerror

@gustawdaniel
Copy link
Contributor Author

I think that I fixed it, but please for review and more info about how to run test to this package when I created a fork.

What I did:

  1. git clone
  2. docker-compose up
  3. npm run test

What I see:

  1. Not found file:
no such file or directory, open '/home/daniel/pro/interview_record/local/create-fastify-app/test/workdirSwagger/package.json'

And it is true. There is no this file.

Zrzut ekranu z 2020-08-30 11-23-22

@gustawdaniel
Copy link
Contributor Author

So I propose:

  1. Remove tests of workdir
  2. Add workdir directory and his content to test directory in git

@gustawdaniel
Copy link
Contributor Author

This proposition is directed to @davidedantonio because of he is creator of file:

create-fastify-app/test/generate.project.swagger.test.js

https://github.com/davidedantonio/create-fastify-app/commits/master/test/generate.project.swagger.test.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant