reload could fail if one site antares operation fails #34
Comments
ahmelsayed
pushed a commit
that referenced
this issue
Sep 16, 2016
* Update PingSite to Logic App GA schema 2016-06-01 schema no longer requires app service to be created. * Changes to support Try Functions (#34) * Add indexes to Analytics tables, Allow for multiple adminUserIds * temporarily rename solution file to allow for kudu CI * use proect in .deployment file * Add deleteUserResource Admin API. Enable InitFunctionsContainer * Add missing HttpGet attribute * Init FunctionsContainer Site * 1) Use ServerFarm , initial checkin. 2) UserName API. 3( Resourcegroup Cleanup from Console * Setup FUnctions containers and ApiApps * add optional sbhow freeSItes variable to /resources/all * make showFreeSites optional * Fix optional parameter and add messages on delete user api calls * Fix exceptions when setting up new subscriptions. Reduce sgeoregions to 10 * Create debug build * Create debug build fix input parameter * Create debug build fix input parameter again * Set Site Kind when loading into resourcegroup tentatively skip loading API and Logic Apps * Change build arg specification to -p from /p * Remove rbac access call for api and logic apps * Add csmId for Functions * Move Models files to Models folder * Move Models files to Models folder * fix scmtype for functions containers * Deleted Commented lines out * Allow non liveid identitites for Functions * Return 403 for functions portal requests * Update FunctionsPortal Header Name * Allow LoginUrl to be read by functionsportal * Update state to be used after redirect * Change redirecturi to tryfunctionspage * add redirect to function site * pass in functions source url to state param and read it back to redirect to calling url * Update state string to Header referer * add a bandaid redirect in global.asax.cs * some more checks * fix default redirect * update response statuscode to 302 after return from auth provider * redirect with cookie in querystring * Fix redirect url * Move the redirect logic to the authenticate event * Move redirect functions code to the right location * Move the redirect logic around one mroe time... * Split with & * Add allowcreds cors header * remove reffs to cos pacakge * move cors headers to authenticate * Move cors logic to api code... skip appservice middleware,s icne credentials support doesnt work * skip auth for function portallrequest * read bearer token if its present * fix auth header check * Remove HttpPost attribute for createresource. seems to be causing http404 for options * Try removing EnableCors Attribute * remove cors assembly * add slot routing explicitly * update slotname in redirect_uri * put x-ms-routing-name in cookie when calling auth provider * return functionsresourcegroup * return functions resource when functions is requested in create resource * fix querystring namespce for apicontroller * Model Changes, and google auth provider redirect updates * remove / from state and add bearer token in response back * Send token as queryparam for now * Remove the extra slash that causes /try/ to be interpreted as / in context.Request.Path * Return FunctionsUIResource if functions was requested. Not really needed now, but good to have same flow as /api/resource * No need to return storage account since only the appsetting name is used and its always constant for try * Update redirect state in providers * encrypt cookie before sending out * remove re-encryption of the sessioncookie * Fix missing } * Create TryFunctionsStorageAccount AppSetting and remove unused code * remove tryfunctions storage config name * Update Global.asax.cs * PR Changes. Code refactoring. * Cleanup SimplaeWAWS.Models fodler and refactor SecurityManager.IsAdmin * Dereks change for PingSite.json * Add indexes to Analytics tables, Allow for multiple adminUserIds * temporarily rename solution file to allow for kudu CI * use proect in .deployment file * Add deleteUserResource Admin API. Enable InitFunctionsContainer * Add missing HttpGet attribute * Init FunctionsContainer Site * 1) Use ServerFarm , initial checkin. 2) UserName API. 3( Resourcegroup Cleanup from Console * Setup FUnctions containers and ApiApps * add optional sbhow freeSItes variable to /resources/all * make showFreeSites optional * Fix optional parameter and add messages on delete user api calls * Fix exceptions when setting up new subscriptions. Reduce sgeoregions to 10 * Create debug build * Create debug build fix input parameter * Create debug build fix input parameter again * Set Site Kind when loading into resourcegroup tentatively skip loading API and Logic Apps * Change build arg specification to -p from /p * Remove rbac access call for api and logic apps * Add csmId for Functions * Move Models files to Models folder * Move Models files to Models folder * fix scmtype for functions containers * Deleted Commented lines out * Allow non liveid identitites for Functions * Return 403 for functions portal requests * Update FunctionsPortal Header Name * Allow LoginUrl to be read by functionsportal * Update state to be used after redirect * Change redirecturi to tryfunctionspage * add redirect to function site * pass in functions source url to state param and read it back to redirect to calling url * Update state string to Header referer * add a bandaid redirect in global.asax.cs * some more checks * fix default redirect * update response statuscode to 302 after return from auth provider * redirect with cookie in querystring * Fix redirect url * Move the redirect logic to the authenticate event * Move redirect functions code to the right location * Move the redirect logic around one mroe time... * Split with & * Add allowcreds cors header * remove reffs to cos pacakge * move cors headers to authenticate * Move cors logic to api code... skip appservice middleware,s icne credentials support doesnt work * skip auth for function portallrequest * read bearer token if its present * fix auth header check * Remove HttpPost attribute for createresource. seems to be causing http404 for options * Try removing EnableCors Attribute * remove cors assembly * add slot routing explicitly * update slotname in redirect_uri * put x-ms-routing-name in cookie when calling auth provider * return functionsresourcegroup * return functions resource when functions is requested in create resource * fix querystring namespce for apicontroller * Model Changes, and google auth provider redirect updates * remove / from state and add bearer token in response back * Send token as queryparam for now * Remove the extra slash that causes /try/ to be interpreted as / in context.Request.Path * Return FunctionsUIResource if functions was requested. Not really needed now, but good to have same flow as /api/resource * No need to return storage account since only the appsetting name is used and its always constant for try * Update redirect state in providers * encrypt cookie before sending out * remove re-encryption of the sessioncookie * Fix missing } * Create TryFunctionsStorageAccount AppSetting and remove unused code * remove tryfunctions storage config name * Update Global.asax.cs * PR Changes. Code refactoring. * Cleanup SimplaeWAWS.Models fodler and refactor SecurityManager.IsAdmin * Dereks change for PingSite.json * Fix Xamarin icon. Fixes #37 * remove unnecessary checks in InitFunctionsContainer, update Container version, * Add paranthese in delete resourcegroup logic * recreate orphaned resourcegroups when doing /reload * Force MakeTrialSubscription on load * Update tracking scripts * Update loc resources * Move Model Classes back to /Models folder * refactor subscription load * Initial support for Create Jenkins resource * Check for VM IP and update on get /resource for Jenkins resources * Add a JenkinsUrlPopulated flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if an antares operation (change config, query, etc) fails for a site, the entire reload operation could fail. Ideally only that site will fail the reload.
I haven't quite figured out where that is happening as there are multiple places where it could happen. Ideally any operation should be guarded.
also for completeness, the timer should check the webspaces, not just the sites.
The text was updated successfully, but these errors were encountered: