Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links don't match actual params #77

Open
amcaplan opened this issue Mar 6, 2017 · 0 comments
Open

Links don't match actual params #77

amcaplan opened this issue Mar 6, 2017 · 0 comments

Comments

@amcaplan
Copy link

amcaplan commented Mar 6, 2017

This gem allows the use of custom page size and number params. However,

new_params = request.query_parameters.merge(:page => v)
seems to indicate that regardless of the params set, it assumes that the page number param is just called :page. Shouldn't that be keyed off the configuration instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant