Skip to content

Commit bb678ba

Browse files
zhifengzhuangqinghuan
andauthored
fix: bug in SetPages (#421)
Co-authored-by: qinghuan <[email protected]>
1 parent d2d2a1f commit bb678ba

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

vips/image.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ func (r *ImageRef) SetPages(pages int) error {
766766
return err
767767
}
768768

769-
vipsSetImageNPages(r.image, pages)
769+
vipsSetImageNPages(out, pages)
770770

771771
r.setImage(out)
772772
return nil

vips/image_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,6 +1169,18 @@ func TestImageRef_HistogramEntropy(t *testing.T) {
11691169
require.True(t, e > 0)
11701170
}
11711171

1172+
func TestImageRef_SetPages(t *testing.T) {
1173+
Startup(nil)
1174+
1175+
image, err := NewImageFromFile(resources + "gif-animated.gif")
1176+
require.NoError(t, err)
1177+
require.Equal(t, 8, image.Pages())
1178+
1179+
err = image.SetPages(3)
1180+
require.NoError(t, err)
1181+
require.Equal(t, 3, image.Pages())
1182+
}
1183+
11721184
// TODO unit tests to cover:
11731185
// NewImageFromReader failing test
11741186
// NewImageFromFile failing test

0 commit comments

Comments
 (0)