Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Reduce amount of warnings #1944

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

lbonn
Copy link
Collaborator

@lbonn lbonn commented Feb 16, 2024

Remove some warnings which pop up when building rofi and hide real issues when developing

  • one unused parameter in recursivebrowser.c
  • overlength strings are overly pedantic, modern compilers support large strings
  • __FUNCTION__ creeped back in after warning: ISO C does not support #288

What's left:

  • non conformant cast in libgwater
../subprojects/libgwater/xcb/libgwater-xcb.c:160:35: warning: ISO C forbids conversion of object pointer to function pointer type [-Wpedantic]
  160 |     g_source_set_callback(source, (GSourceFunc)(void *)callback, user_data, destroy_func);
  • unchecked return values (always write(), dmenu.c and recursivebrowser.c)
../source/modes/dmenu.c:309:19: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  309 |                   write(pd->pipefd2[1], "r", 1);

* one unused parameter in recursivebrowser.c
* overlength strings are overly pedantic, modern compilers support large
  strings
* __FUNCTION__ creeped back in after davatorium#288
@DaveDavenport DaveDavenport merged commit f539a08 into davatorium:next Feb 16, 2024
8 checks passed
@lbonn lbonn deleted the less-warnings branch February 17, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants