[BUG] "window" mode doesn't show fullscreen windows

[sinexl]

Rofi version (rofi -v)

Version: 1.7.6-dirty

Configuration

https://gist.github.com/sinexl/a69e9c17849af33c307250dfb7b4da5b

Theme

https://gist.github.com/sinexl/a69e9c17849af33c307250dfb7b4da5b

Timing report

No response

Launch command

rofi -no-lazy-grab -normal-window -show window -modi window

Step to reproduce

• Open terminal (tested on Alacritty and WezTerm)
• Put terminal window in fullscreen mode
• Run rofi with mentioned command and notice that it doesn't show any fullscreen windows, including terminal it was launched from
  
  (Note: for screenshot i also resized rofi to not cover whole screen, although it doesn't affect the result)

Expected behavior

Rofi would show fullscreen windows in list

Actual behavior

Rofi doesn't show any windows that are fullscreen

Additional information

OS: EndeavourOS, WM: AwesomeWM

Using wayland display server protocol

• No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[DaveDavenport]

Cannot reproduce this on endevourOs and awesomewm..

I in this list I see all open windows, including the fullscreen one.

I did notice a pinned window does not show up.

[sinexl]

I think the problem is due to something different then. I've tried to log in from different user without any configuration files to Awesome/Rofi and still same bug occurs.

[DaveDavenport]

You put it in fullscreen using Win+F? or any other way?

[sinexl]

You put it in fullscreen using Win+F? or any other way?

Yes. I've also noticed this bug for windows that are maxemized (On telegram desktop specifically)

[DaveDavenport]

I wonder why it behaves differently here.. maximize is fine. I also don't see anything in the code that could do this.

[DaveDavenport]

Can you do a xprop on a windows that does not show and pastebin the output?

[DaveDavenport]

diff --git a/source/modes/window.c b/source/modes/window.c
index 27798c81..50d78c2a 100644
--- a/source/modes/window.c
+++ b/source/modes/window.c
@@ -296,7 +296,7 @@ window_get_attributes(xcb_window_t w) {
 // _NET_WM_STATE_*
 static int client_has_state(client *c, xcb_atom_t state) {
   for (int i = 0; i < c->states; i++) {
-    if ((c->state[i] & state) == state) {
+    if ((c->state[i]) == state) {
       return 1;
     }
   }

does this fix it?

Not sure why I changed this anymore.. But this might not be right.. (damn lack of clear documentation on xcb_*)

[DaveDavenport]

is also on git, so the rofi-git aur should also be ok to test...
thanks.

[sinexl]

Can you do a xprop on a windows that does not show and pastebin the output?

Here are some of them
https://pastebin.com/XMz0wLf4

[sinexl]

is also on git, so the rofi-git aur should also be ok to test... thanks.

Now it works! Thank you so much!

[DaveDavenport]

Thanks for testing!