Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rofi takes 3s to starts, if icons are enabled #2005

Closed
1 of 2 tasks
PerchunPak opened this issue Jul 14, 2024 · 11 comments
Closed
1 of 2 tasks

[BUG] rofi takes 3s to starts, if icons are enabled #2005

PerchunPak opened this issue Jul 14, 2024 · 11 comments
Labels

Comments

@PerchunPak
Copy link

PerchunPak commented Jul 14, 2024

Rofi version (rofi -v)

1.7.5

Configuration

-no-config

Theme

-no-config

Timing report

https://gist.github.com/PerchunPak/203502ba0b2e82bbe8ceeb4fcbf055cf

Launch command

rofi -drun-use-desktop-cache -show drun -no-config -show-icons

Step to reproduce

  • run rofi -drun-use-desktop-cache -show drun -no-config -show-icons and start pressing keys, rofi doesn't react

Expected behavior

rofi should react instantly

Actual behavior

rofi doesn't react for 3 seconds (turn on sound)

rofi.mp4

Additional information

The issue is the same if I remove -drun-use-desktop-cache

I use NixOS on unstable branch (NixOS/nixpkgs@7e7c39e) and hyprland v0.41.2 (which also means I use Wayland, I don't know why am I required to say that I don't even when wiki page says you support Wayland)

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@PerchunPak PerchunPak added the bug label Jul 14, 2024
@PerchunPak
Copy link
Author

PerchunPak commented Jul 14, 2024

Also tried to build from source on 8eb8ff3 and it didn't help as well.

EDIT: Though build from next also takes a second to start even if I just use rofi -show drun -no-config (but if I enable icons, it starts even longer)

@lbonn
Copy link
Collaborator

lbonn commented Jul 14, 2024

@PerchunPak Which version of rofi was your original report for? (rofi -version)

Not sure it is related to the slowdown but there are two packages in nixpkgs, one with wayland support from the fork: https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/misc/rofi

If you were using mainline rofi for both of your tests, maybe try also with the wayland version with timing reports as well.

@PerchunPak
Copy link
Author

oh yeah, rofi-wayland works. sorry for the confusion

@PerchunPak PerchunPak closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
@DaveDavenport
Copy link
Collaborator

(which also means I use Wayland, I don't know why am I required to say that I don't even when wiki page says you support Wayland)

Where does it say this? this should be fixed then.

@PerchunPak
Copy link
Author

Where does it say this? this should be fixed then.

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Jul 15, 2024

Sorry for being unclear, where in the wiki does it say we support wayland?

The question in the bug report is there as it helps pin-point problems and redirect people to the right issue tracker.

@PerchunPak
Copy link
Author

Yes, something like "current release doesn't support wayland, so you should use the fork" would guide me in the right direction

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Jul 15, 2024

like the current text on the wiki?

A pull request was opened to allow Rofi to work under Wayland with Sway and some other window managers. If you are are interested, check out the fork that was spun off from the PR and send your feedback there.

Sorry for being unclear, where in the wiki does it say we support wayland?

can you please point out where?

@PerchunPak
Copy link
Author

PerchunPak commented Jul 16, 2024

Exactly here, changing it to would guide me in the right direction, because for some reason I didn't check linked PR and assumed it was merged

A pull request was opened to allow Rofi to work under Wayland with Sway and some other window managers, but it wasn't merged. If you need proper Wayland support, check out the fork that was spun off from the PR and send your feedback there.

(Changed parts are bold)

You can also ignore this as my skill issue, since I didn't know that PR was closed until now

@DaveDavenport
Copy link
Collaborator

Thanks, changed the text.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants