Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] -disable-history not working #1995

Open
2 tasks done
haennes opened this issue Jul 3, 2024 · 9 comments
Open
2 tasks done

[BUG] -disable-history not working #1995

haennes opened this issue Jul 3, 2024 · 9 comments
Labels

Comments

@haennes
Copy link

haennes commented Jul 3, 2024

Rofi version (rofi -v)

Version: 1.7.5+wayland3

Configuration

https://gist.github.com/haennes/9b100643da1e93aa4ea9845688002d83

Theme

https://gist.github.com/haennes/494f96e6a339701f9bb2422639d0c223

Timing report

No response

Launch command

rofi -dmenu -disable-history -no-fixed-num-lines -l 1 -i -input /dev/null -password -p "Passphrase:"

Step to reproduce

run rofi -dmenu -disable-history -no-fixed-num-lines -l 1 -i -input /dev/null -password -p "Passphrase:"

Expected behavior

doesnt write anything to $XDG_CACHE_HOME/rofi-entry-history.txt (i.e. ~/.cache/rofi-entry-history.txt)

Actual behavior

outputs a password to this file

Additional information

I actually am on wayland, but this is completely irrelevant for this bug

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@haennes haennes added the bug label Jul 3, 2024
@DaveDavenport
Copy link
Collaborator

good catch, the entry history should also be disabled.

@haennes
Copy link
Author

haennes commented Jul 5, 2024

Sorry, but I have no clue on how to fix that myself.....
I tried but failed to understand the code structure :/

@DaveDavenport
Copy link
Collaborator

ill fix it when I have time.

@DaveDavenport
Copy link
Collaborator

commited code that should fix the code disabling it when -password is passed.
It also disables it with -disable-history.

@haennes
Copy link
Author

haennes commented Jul 7, 2024

doesnt fix it on my machine. Have actually confirmed i am using the right rofi using nix repl....
Behaviour is still the same as before.
I am not sure enough though, can you reproduce? (still same cmd as in original post)
This shouldnt have anything to do with me using wayland as it is such a core functionality (i am using this git repo as a source anyways), right?

@DaveDavenport
Copy link
Collaborator

you are not using this repository. you are using @lbonn his fork.

@trinitronx
Copy link

you are not using this repository. you are using @lbonn his fork.

Yes, the fixes will have to be merged into the lbonn/rofi fork from this repo (git merge upstream/next).

@jmonroynieto
Copy link

Would you consider creating a command to disable it once it is already running? A command to send a message to toggle which would be caught by the daemon could be fantastic. I am running it as a systemd service and having to kill it and then relaunch it is a bit of a friction point.

I envision a timer too. my use case involves fetching passwords from my manager, having it so that I don't have to toggle it back again sounds very appealing. I'm not a C developer so I can't offer a PR in any reasonable timeframe.

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Aug 23, 2024

@jmonroynieto I don't understand your request in the context of rofi. But please make a new discussion on this (see guidelines!) , so we don't pollute this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants