[BUG] Icon fetcher fails to load icons/thumbnails for animated GIFs

[martinsifrar]

Rofi version (rofi -v)

Version: 1.7.5, also checked on (next 1.7.5-228-g6c38a49d)

Configuration

https://gist.github.com/martinsifrar/e2b3724060c81bafe4682698d2252174

Theme

https://gist.github.com/martinsifrar/5343660f12cd4fd8cec0125ba5296899

Timing report

No response

Launch command

rofi -show-icons -show filebrowser

Step to reproduce

• Start rofi filebrowser with -show-icons option
• Navigate to a folder containing an animated GIF (example file to reproduce)

Expected behavior

Rofi should show the first frame of the animated GIF.

Actual behavior

The thumbnail is not shown. Rofi prints out a debug Helpers.IconFetcher-WARNING warning

(process:360901): Helpers.IconFetcher-WARNING **: 12:01:47.513: Failed to load image: |/home/martin/testgif/animated/rotating-95.gif| 23 23 Not all frames of the GIF image were loaded. (0x7ee188003970)

Additional information

No response

Using wayland display server protocol

• No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

• Yes, I have checked the problem exists in the latest stable version

[DaveDavenport]

We use gdkpixbuf for image loading, I think this might be relevant: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/45

[martinsifrar]

We use gdkpixbuf for image loading, I think this might be relevant: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/45

I already had the fix running on my computer. It just kinda took me a while to make the issue and the PR, as I'm not very used to Github.

[DaveDavenport]

Thanks for the PR! merged.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.