-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Including Select All Text as keybinding #1912
Comments
Can you provide a use-case of what a 'select all text in input' would improve? Please answer the questions asked in the template.
This answers that the proposed solution does not exists, not the problem.
This is not an answer to the question asked. |
It saves time by eliminating the need to select individual strings, so quick text manipulation; copy and paste, for example if I write some string there, and I need to copy and paste somewhere, I can do it quickly; accessibility, maybe it can give a little help to people that could have some disabilities.
This is not a problem. This is a feature request. Maybe the question should be rephrased, or maybe the question "What are the problems you are facing without this feature?" is needed.
Of course my dear we can have a different perception on how this kind of features can be important, for example a "select all text" could sound trivial on your side but for the average users the perception/feeling on this could be different. Feel free to consider it. If not, don't worry. |
Given that rofi does not support text selection, I am still unsure what problem you are trying to solve with a 'select all text' keybinding. This is why this is asked.
You cannot select individual strings in rofi. I am now even more confused by your feature request and your reason for it?
you can paste into rofi, or copy the selected entry to clipboard (git).
Can you explain how this feature would help?
There are a lot of keybindings implemented in rofi to help with editing the text in the entry. like delete word forward/back, move word forward back, move to start/end, delete to start/end etc. Clear line, etc. As I mentioned before, I am willing to consider feature requests, but it helps to have a clear use-case for it or problem it solves. Given rofi's current features I do not see a use-case or the problem it solves. |
Nevermind, we can close the ticket. |
Why not answer the question? I would like to improve usability where possible, but I truely do not see what improvement a keybinding that selects all text would bring? So can you please describe the use-case for this feature? or describe the problem that is there and this addition would fix. This would help me, and the people I asked to help me understand the request, understand what you want added.
It is hard to judge the importance of the feature if I don't understand the problem it tries to resolve. |
Not sure if I can explain better than my previous comments, but it is my problem that Im not able to transmit my feeling. Let's see if other users join this discussion to share their point of view. |
I tried to break down your previous comment, but you have not replied on my breakdown and the questions in there. I really tried to understand, so lets try this again. Your comment that provided more explanation was:
I'll try to break it down again and be more verbose:
We do not have support for making a selection in the entry box of rofi. So this one I do not understand, how does selecting all text eliminates the need for something that is not supported in the first place. Is the request for text selection then? If yes, we can discuss this.
Lets split this in two:
Is this the problem we are trying to solve? if yes, we can discuss this.
I really would like to improve usability to people with disabilities, but this to me does not add more information. |
What I mean needs the selection in the entry box of rofi, so if it is not supported, the entire request falls. Because a simple use case I'm imaging now is: I have rofi to search applications. Let's guess I write on rofi bar
Ok for paste, I agree with you. About copy, a use case could be the same example I did above, where I want to only one string of the entire input, for example Nightly, but still it needs the support of text selection.
Related to copy topic, yes but not the only one (look my comment here above about copy to copy substrings)
Sorry if I'm still unclear. |
There is already a feature implemented to make this easier; there currently exists a keybinding to delete one word back, so the above usecase takes hitting this keybinding twice to do what you want efficiently. This is a different request then the original feature request, where you wanted to a 'select all'.
This is also again different then the original feature request and further explanation.
Copying the content of the entire entry box I can easily add. So I think the request is adding support for text selection. I'll try to answer this one: First this is a non-trivial feature to add in the current implementation but doable. It would be a big investment of time to get this done. I am very short on time, answering question takes up most time I have already. So development time is very limited. (I haven't found time to make a new release for the past half year). So this needs to be heavily upvoted issue, or somebody needs to provide an PR. I personally think most of the use-case for a selection (beside copy (1)) is already possible via the keyboard: Rofi main utility is a keyboard driven filter for interacting with lists. Mouse interaction is mostly an afterthought and not its focus.
Using copy can be useful for moving (sub)strings in the textbox of rofi, this is normally not needed as ordering of the words (unless configured differently) does not affect the behaviour (its a tokenized search). (firefox nightly should give same result as nightly firefox). [1] copy is something I have not added until recently to rofi. This is because how clipboards (to my understanding) works in X11 is that the application that has the selection owns it. So if the application is closed, the selection is gone and you cannot paste the text anymore. Given that rofi is a modal application that blocks interaction with other application while it is running, copying text to the clipboard is normally gone at the point the user would want to paste it somewhere else. An external clipboard manager could fix this, this is why I've added it in git (for copying the selected entry in the listview, the things that has been requested in the past). |
Thank you very much for the detailed explanation. |
my use case is: sometimes when i type sth wrong, i just want to select all and delete and type again. it's just my personal habbit. |
@tuananh there are keybindings to quickly clear input. It would not save any keystrokes. |
Thanks. That works for me. |
closing this issue for now . Copy has been implemented now and I think my above should be sufficient. If somebody has a very good use-case (please read this whole post) please open a new issue. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Before opening a feature request
What is the user problem or growth opportunity you want to see solved?
To improve efficiency on the usage, I would like to have for me and for the users the chance to configure the keybinding to select all the text typed in Rofi textbox.
How do you know that this problem exists today? Why is this important?
I gave a look on https://github.com/davatorium/rofi/blob/next/doc/rofi-keys.5.markdown but I don't see it.
Who will benefit from it?
Improve efficiency on text manipulation.
Rofi version (rofi -v)
Version: 1.7.5
Configuration
https://gist.github.com/D3vil0p3r/3e814ffc4f11386021c0da9774c49752
Additional information
No response
The text was updated successfully, but these errors were encountered: