Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

However, rofi uses black text instead in the newer releases. #1886

Closed
2 tasks done
ReneFroger opened this issue Aug 8, 2023 · 5 comments
Closed
2 tasks done

However, rofi uses black text instead in the newer releases. #1886

ReneFroger opened this issue Aug 8, 2023 · 5 comments
Labels

Comments

@ReneFroger
Copy link

ReneFroger commented Aug 8, 2023

Rofi version (rofi -v)

1.7.1 and 1.7.5

Configuration

https://gist.github.com/ReneFroger/7081306666fe8f7136b9bb4a8c427c3b

Theme

https://gist.github.com/ReneFroger/40f6ba1c4f422f0ec3479aa2da8be76b

Timing report

No response

Launch command

rofi -show drun

Step to reproduce

In rofi 1.5.4 with the Mycustomtheme (As indicated in the confirguration file and theme file) I have the following output with rofi -show drun:

image

It works fine.

When I upgraded my system to 22.04, the new rofi version is included.

The version is 1.7.1. But the output of `rofi -show drun looks however like this:

image

Expected behavior

The foreground property should be recognized by Rofi.

Actual behavior

I tried to debug it with making everything white in my theme file. When launch rofi -show drun with the adjusted theme file, everything is white except the text of application files, they stay black whereas they should be supposed to be white too . So I suspect there might another foreground property in the newer releases of Rofi, because the changed value for foreground are not 'seen' by Rofi (as in that the text stays black). Or it doesn't exist anymore for Rofi. I looked into the documentation what might be changed there, but it wasn't mentioned there, only that there were more dynamic variables added for themes.

So the conclusion is that rofi in the newer releases uses system-wide text color/black text instead of the color in theme configuration, and doesn't take foreground property into consideration for text.

Additional information

No response

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@ReneFroger ReneFroger added the bug label Aug 8, 2023
@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Aug 8, 2023

Did you read? #1397. It is pinned on the issue page.

@DaveDavenport
Copy link
Collaborator

I looked into the documentation what might be changed there, but it wasn't mentioned there, only that there were more dynamic variables added for themes.

It is:
https://github.com/davatorium/rofi/releases/tag/1.7.0

@DaveDavenport
Copy link
Collaborator

Closing. Not bug.

@DaveDavenport DaveDavenport closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
@ReneFroger
Copy link
Author

I couldn't find it earlier when looking on "foreground", but thanks for letting me know. All your work for Rofi is really appreciated, Dave!

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants