Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Investigate generating Organization and Repository objects vs. fetching from GitHub #24

Open
shevron opened this issue Jul 23, 2020 · 0 comments

Comments

@shevron
Copy link
Contributor

shevron commented Jul 23, 2020

See if we can instantiate these objects based on data we already have (the org name and package ID) instead of fetching them from GitHub via API. This can reduce a lot of repeating calls in a bunch of different methods.

Both objects have the ability to "lazy-fetch themselves" ("complete") from GitHub if a property of them that was not pre-populated is needed, so this technique can probably work and be harmless, but we should still see if it can be done and if it can actually improve performance, or are we going to call __complete in any case regardless, and then the added complexity is not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant