Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Eliminate calls to PyGithub __completeIfNeeded #23

Open
shevron opened this issue Jul 23, 2020 · 0 comments
Open

[performance] Eliminate calls to PyGithub __completeIfNeeded #23

shevron opened this issue Jul 23, 2020 · 0 comments

Comments

@shevron
Copy link
Contributor

shevron commented Jul 23, 2020

During the analysis for #17, we detected many cases where PyGitHub is missing some value that it needs, thus calling __completeIfNeeded which triggers an additional API call.

We should investigate all cases where this happens, to see if it can be avoided by proving some additional values when instantiating objects or calling methods, thus avoiding PyGitHub's need to fetch those values from the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant