Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup from new UX #910

Open
22 of 33 tasks
baltpeter opened this issue Jul 14, 2022 · 23 comments
Open
22 of 33 tasks

Cleanup from new UX #910

baltpeter opened this issue Jul 14, 2022 · 23 comments
Assignees
@baltpeter @zner0L
Labels
cleanup

Comments

@baltpeter
Copy link
Member

baltpeter commented Jul 14, 2022 •
edited by zner0L
Loading

In the interest of moving forward, we'll soon merge website#895 into new_ux.

But the following still needs to be addressed before new_ux can be merged into master:

  • CompanySearchPage needs to respect the privacy controls. @baltpeter
  • Functional "Export to calendar" button on "What's next" page.
  • Added fill fields shouldn't be marked as required. @zner0L
  • Fix "[object Object]" at the top of the "copy manually" text of PDF requests.
  • Support other languages than EN in app.
  • User cannot mark manually copied request as sent. @zner0L
  • In the arrow thing at the top, long company names should be elided instead of spanning multiple rows. @zner0L
  • The "add input" dropup is cut off if it has too many elements. @zner0L
  • Enable noUncheckedIndexedAccess in tsconfig.json.
  • Checkbox for tracking requests.
  • Write many, many tests.
    • From wizard-regressions:
      • Ensure that we actually go through all added companies.
      • Ensure that done companies are correctly reflected in the "breadcrumbs".
    • From wizard:
      • Ensure translation macros work.
    • From country-change-updates-wizard:
      • Ensure changing the country changes the company packs.
    • Test parameters in old and new generator
  • Support old URLs in new generator.
  • Mention old generator in new generator if user has an existing request from before today.
  • Link old generator in the footer.
  • Mention new generator in the old one.
  • Get rid of the "wizard" and react-joyride @baltpeter
  • Pretty new homepage.
  • Handle browser back/forward navigation.
  • Global settings page with settings for:
    • Transport medium (use suggested (default) or always override with x)
    • "Request machine-readable data in access requests" (defaults to true)
  • Collapse MailtoDropdown to mere mailto: link on mobile.
  • Persist the state.
  • Proper "What's next" page.
  • Improve the "Your GDPR rights" blog post.
  • I know I've said it before but I don't think the blue background is an intuitive way to indicate a selected state. This seems more like a hovered/focussed state. This is especially true if there is only one result (e.g. if you search for "google").
  • Decide how to integrate app into the website #935
  • If we do: Proper meta data for app page.
  • Flow for requesting companies not in the database!
  • Do we need to call renderLetter()?
  • Write an introductory text for the RequestTypeChooserPage.
@baltpeter
Copy link
Member Author

baltpeter commented Jul 14, 2022 •
edited
Loading

We'll also need to address the user testing feedback:

@zner0L
Copy link
Member

zner0L commented Jul 15, 2022 •
edited
Loading

  • The focus should be reset to the company chooser modal in the company packs (otherwise you need to tab through the whole page) @zner0L
  • Which reminds me: Our modals are not a11y-friendly, yet. @zner0L
  • Ability to mark requests as send if you just copied the text (maybe a keyboard listener?) @zner0L
  • Fix jumping buttons in the company modal @zner0L
  • Fix non-focusable MailtoDropdown options @zner0L
  • I think we need to indicate somehow if (some of) a company pack was added. Currently, the user can not be sure just from the company packs UI.

baltpeter added a commit that referenced this issue Jul 15, 2022
@baltpeter @zner0L
New UX design for the request generator (#895)
73ffffc 
This commit implements a new UX design for the request generator that will eventually
replace the existing one.

The new design most notably uses a wizard-style flow to guide the user through the
process instead of overwhelming them with all questions on a single page like the
initial design.

The design is not finalized yet, and we will continue to iterate on it. Major open issues are
listed in #910.

Co-authored-by: Lorenz Sieben <[email protected]>
Co-authored-by: Benjamin Altpeter <[email protected]>
@zner0L
Copy link
Member

zner0L commented Aug 1, 2022

@zner0L
Copy link
Member

zner0L commented Aug 1, 2022 •
edited
Loading

  • Get rid of setCustomLetterTemplate

@zner0L
Copy link
Member

zner0L commented Aug 2, 2022

  • Pagination in proceedings list

@baltpeter
Copy link
Member Author

baltpeter commented Aug 30, 2022 •
edited by zner0L
Loading

  • Delete blobs from deleted messages (in the app-apps).
  • Properly fix idb bug: "Uncaught DOMException: The operation failed because the stored database is a higher version than the version requested."

@baltpeter
Copy link
Member Author

baltpeter commented Sep 28, 2022 •
edited
Loading

  • ID data explanation text isn't correct for tracking requests.

@baltpeter
Copy link
Member Author

baltpeter commented Oct 11, 2022 •
edited
Loading

@baltpeter
Copy link
Member Author

baltpeter commented Oct 15, 2022 •
edited by zner0L
Loading

@baltpeter
Copy link
Member Author

baltpeter commented Oct 17, 2022 •
edited
Loading

Also: I am always setting the content in Reactor, whereas the generator doesn't do that. Do we want to keep doing that?

@baltpeter
Copy link
Member Author

baltpeter commented Oct 19, 2022 •
edited
Loading

  • SvaFinder styling is broken again

@baltpeter
Copy link
Member Author

baltpeter commented Oct 26, 2022 •
edited
Loading

@baltpeter
Copy link
Member Author

baltpeter commented Oct 26, 2022 •
edited
Loading

@baltpeter
Copy link
Member Author

baltpeter commented Oct 28, 2022 •
edited
Loading

  • Transparency details

@baltpeter
Copy link
Member Author

  • Blog post about the launch

@zner0L
Copy link
Member

zner0L commented Nov 4, 2022 •
edited by baltpeter
Loading

  • Button to "reactivate" done requests

@zner0L zner0L mentioned this issue Nov 29, 2022
Merged
@baltpeter
Copy link
Member Author

baltpeter commented Nov 29, 2022 •
edited
Loading

  • Fix padding in multi-line buttons.

image

@baltpeter
Copy link
Member Author

baltpeter commented Dec 1, 2022 •
edited by zner0L
Loading

  • The "generate admonition/complaint based on your answers" button after entering some issues in reactor should be highlighted (thanks, @mal-tee).

@baltpeter
Copy link
Member Author

baltpeter commented Dec 1, 2022 •
edited by zner0L
Loading

  • The radio buttons don't have a focused state. :o

@baltpeter
Copy link
Member Author

baltpeter commented Dec 4, 2022 •
edited by zner0L
Loading

  • Update hint request cut-off date.

@baltpeter
Copy link
Member Author

@mal-tee
Copy link
Member

mal-tee commented Dec 9, 2022 •
edited by zner0L
Loading

@mal-tee mal-tee changed the title Cleanup from website#895 Cleanup from new UX Dec 9, 2022
@mal-tee mal-tee pinned this issue Dec 9, 2022
@mal-tee
Copy link
Member

mal-tee commented Dec 9, 2022 •
edited
Loading

I took the liberty of renaming this, since we merged. 🥳 Might be easier for our users to find known-bugs this way.

@zner0L zner0L unpinned this issue Jan 18, 2023
@zner0L zner0L pinned this issue Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baltpeter baltpeter

@zner0L zner0L

Labels
cleanup
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baltpeter @zner0L @mal-tee