New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment rating should be a number #53

Open

zner0L opened this issue Mar 21, 2022 · 1 comment

Labels

bug

Member

zner0L commented Mar 21, 2022

Apparently, the backend currently treats rating numbers as strings. This makes no sense, as pointed out by this comment: https://github.com/datenanfragen/website/pull/872/files#diff-79762f6bf029b23635833cbb41d691bdb1913a7d8e6a5ce6727b706c5acb0d57R17

zner0L added the bug label

Member

baltpeter commented Mar 21, 2022

Iirc, the problem is that Knex returns everything as a string and we need to convert it to a number manually.

See: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment