Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport protocol version crd #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,17 @@ Please see the [Envoy documentation](https://www.envoyproxy.io/docs/envoy/latest

## RELEASE NOTES

## [2.3.0] TBD
[2.3.0]: https://github.com/datawire/edge-stack/releases/v2.3.0

## Ambassador Edge Stack

- Feature: Ambassador Edge Stack now supports the use of transport protocol V3 in External Filters while
reatining compatability for V2. To start using transport protocol V3, set the new
`protocol_version` field in an External Filter to `v3`. If the protocol version is not specified
then it will be assumed to be V2 which is the standard in Ambassador Edge Stack versions prior to
2.3. // TODO, link to a docs page that has not yet been created

## [2.2.0] 2022-02-10
[2.2.0]: https://github.com/datawire/edge-stack/releases/v2.2.0

Expand Down
8 changes: 4 additions & 4 deletions charts/edge-stack/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: emissary-ingress
repository: https://s3.amazonaws.com/datawire-static-files/charts
version: 7.3.0
digest: sha256:c4685611ce82ad107714de6910d8bb206d770c8dd6962f501603b2d96e80d2f6
generated: "2022-02-10T12:45:44.975886331-08:00"
repository: https://s3.amazonaws.com/datawire-static-files/charts-dev
version: 7.3.1-0.20220216011017-59cab53eeea6
digest: sha256:e238059eff240e04fde02e2cc3e6419916cbf3bade2b203bdb79244dd2ad8854
generated: "2022-02-16T11:54:38.629585-05:00"
4 changes: 2 additions & 2 deletions charts/edge-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ maintainers:
engine: gotpl
dependencies:
- name: emissary-ingress
version: 7.3.0
repository: https://s3.amazonaws.com/datawire-static-files/charts
version: 7.3.1-0.20220216011017-59cab53eeea6
repository: https://s3.amazonaws.com/datawire-static-files/charts-dev
11 changes: 11 additions & 0 deletions docs/releaseNotes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@

changelog: https://github.com/datawire/edge-stack/blob/$branch$/CHANGELOG.md
items:
- version: 2.3.0
date: 'TBD'
notes:
- title: Support for Envoy Transport Protocol V2 and V3
type: feature
body: >-
$productName$ now supports the use of transport protocol V3 in External Filters while reatining compatability for V2.
To start using transport protocol V3, set the new `protocol_version` field in an External Filter to `v3`. If the protocol version
is not specified then it will be assumed to be V2 which is the standard in $productName$ versions prior to 2.3.
// TODO, link to a docs page that has not yet been created

- version: 2.2.0
date: '2022-02-10'
notes:
Expand Down
10 changes: 10 additions & 0 deletions manifests/edge-stack/aes-crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,11 @@ spec:
that; in External Filters "tls" is a boolean indicating whether
to originate TLS.
type: boolean
v3ProtocolVersion:
enum:
- v2
- v3
type: string
required:
- auth_service
type: object
Expand Down Expand Up @@ -921,6 +926,11 @@ spec:
- http
- grpc
type: string
protocol_version:
enum:
- v2
- v3
type: string
status_on_error:
description: 'TODO(lukeshu): In v3alpha2, consider getting rid
of this struct type in favor of just using an int (i.e. `statusOnError:
Expand Down